New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657276 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Oct 2016
Cc:
█ alokp@chromium.org
sande...@chromium.org
█ roc...@chromium.org
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Media mojo class names need update

Project Member Reported by xhw...@chromium.org, Oct 19 2016 
Mojo has changed a lot of naming scheme (e.g app -> service). As a result, there are some names in media/mojo that are outdated. Here are some that I can think of with proposed new names:

MojoMediaApplication -> MediaService
media::mojom::ServiceFactory -> InterfaceProvider or MediaInterfaceProvider or MediaInterfaceFactory
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602

commit b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602
Author: xhwang <xhwang@chromium.org>
Date: Wed Oct 19 20:55:52 2016

media: Rename MojoMediaApplication to MediaService

This follows the latest mojo naming convention since now
MojoMediaApplication implements service_manager::Service and is
registered for "service:media".

TBR=jam@chromium.org
BUG= 657276 
TEST=Renaming only.

Review-Url: https://chromiumcodereview.appspot.com/2434673002
Cr-Commit-Position: refs/heads/master@{#426278}

[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/chromecast/browser/cast_content_browser_client.cc
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/content/gpu/gpu_service_factory.cc
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/content/utility/utility_service_factory.cc
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/gpu/BUILD.gn
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/media_options.gni
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/BUILD.gn
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/default_mojo_media_client.h
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/main.cc
[rename] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/media_service.cc
[rename] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/media_service.h
[rename] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/media_service_factory.cc
[add] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/media_service_factory.h
[modify] https://crrev.com/b1d65fd3e581cbe64c9b7e9eb47ba08f590e9602/media/mojo/services/mojo_cdm_service.h
[delete] https://crrev.com/935001c5a0b9c97ebf28eded808f7e7bf0b14d43/media/mojo/services/mojo_media_application_factory.h
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7816c8f19d4c1fd94d95f9a77f88087497011a58

commit 7816c8f19d4c1fd94d95f9a77f88087497011a58
Author: xhwang <xhwang@chromium.org>
Date: Tue Oct 25 07:05:57 2016

media: Rename ServiceFactory to InterfaceFactory

Now the meaning of "service" has changed. InterfaceFactory makes more
sense since this is similar to shell_manager::InterfaceFactory.

TBR=dcheng@chromium.org
BUG= 657276 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2444623002
Cr-Commit-Position: refs/heads/master@{#427294}

[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/content/renderer/media/media_interface_provider.cc
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/content/renderer/media/media_interface_provider.h
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/interfaces/BUILD.gn
[rename] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/interfaces/interface_factory.mojom
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/interfaces/media_service.mojom
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/BUILD.gn
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/apptest_manifest.json
[rename] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/interface_factory_impl.cc
[rename] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/interface_factory_impl.h
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/media_manifest.json
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/media_mojo_unittest.cc
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/media_service.cc
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/media_service.h
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/mojo/services/test_manifest.json
[modify] https://crrev.com/7816c8f19d4c1fd94d95f9a77f88087497011a58/media/test/pipeline_integration_test.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680d822c54f4d8e22f0dea66e007ef91f92dfb62

commit 680d822c54f4d8e22f0dea66e007ef91f92dfb62
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Tue Oct 25 08:25:16 2016

media: Remove obsolete include to service_factory.mojom.h

This is missed in the previous CL (r427294).

TBR=jam@chromium.org
BUG= 657276 

Review URL: https://codereview.chromium.org/2449793002 .

Cr-Commit-Position: refs/heads/master@{#427297}

[modify] https://crrev.com/680d822c54f4d8e22f0dea66e007ef91f92dfb62/content/renderer/render_frame_impl.h

Comment 4 by xhw...@chromium.org, Oct 26 2016

Status: Fixed (was: Started)
►

Sign in to add a comment