New issue
Advanced search Search tips

Issue 657273 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 657272
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.3% regression in oortonline_tbmv2 at 425917:425943

Project Member Reported by jgruber@chromium.org, Oct 19 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=657273

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg7c-AqgoM


Bot(s) for this bug's original alert(s):

chromium-rel-mac-retina
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 19 2016

Mergedinto: 657272
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [builtins] implement Array.prototype[@@iterator] in TFJ builtins
Author  : caitp
Commit description:
  
Implements the variations of CreateArrayIterator() in TFJ builtins
(ArrayPrototypeValues, ArrayPrototypeEntries and ArrayPrototypeKeys), and
provides two new Object types with numerous maps which identify certain
behaviours, which will be useful for inlining.

Removes src/js/array-iterator.js entirely

Also adds support for printing Symbol literals inserted by the Parser during
desugaring when FLAG_print_builtin_ast is set to true.

BUG= v8:5388 
R=bmeurer@chromium.org, cbruni@chromium.org
TBR=ulan@chromium.org

Review-Url: https://codereview.chromium.org/2405253006
Cr-Commit-Position: refs/heads/master@{#40373}
Commit  : 86d0dd362f627a7831b042d4fe8baa121c976fc4
Date    : Tue Oct 18 02:43:14 2016


===== TESTED REVISIONS =====
Revision                       Mean    Std Dev  N  Good?
chromium@425916                578154  3105.29  5  good
chromium@425923                576235  2036.02  5  good
chromium@425925                576816  850.92   5  good
chromium@425925,v8@86d0dd362f  584930  409.933  5  bad    <--
chromium@425925,v8@cc07613674  584947  472.258  5  bad
chromium@425925,v8@3145befb3d  584384  593.592  5  bad
chromium@425926                585088  285.153  5  bad
chromium@425927                584824  509.337  5  bad
chromium@425930                600998  36120.9  5  bad
chromium@425943                584648  600.08   5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 657273

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests oortonline_tbmv2
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_max/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:effective_size_max
Relative Change: 1.12%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1751
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998395375566789408


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5283249700470784

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment