New issue
Advanced search Search tips

Issue 657271 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 657272
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

3.1% regression in memory.top_10_mobile at 425920:425937

Project Member Reported by jgruber@chromium.org, Oct 19 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=657271

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg7Y3M-AkM


Bot(s) for this bug's original alert(s):

android-nexus5X
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 19 2016

Mergedinto: 657272
Status: Duplicate (was: Assigned)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [builtins] implement Array.prototype[@@iterator] in TFJ builtins
Author  : caitp
Commit description:
  
Implements the variations of CreateArrayIterator() in TFJ builtins
(ArrayPrototypeValues, ArrayPrototypeEntries and ArrayPrototypeKeys), and
provides two new Object types with numerous maps which identify certain
behaviours, which will be useful for inlining.

Removes src/js/array-iterator.js entirely

Also adds support for printing Symbol literals inserted by the Parser during
desugaring when FLAG_print_builtin_ast is set to true.

BUG= v8:5388 
R=bmeurer@chromium.org, cbruni@chromium.org
TBR=ulan@chromium.org

Review-Url: https://codereview.chromium.org/2405253006
Cr-Commit-Position: refs/heads/master@{#40373}
Commit  : 86d0dd362f627a7831b042d4fe8baa121c976fc4
Date    : Tue Oct 18 02:43:14 2016


===== TESTED REVISIONS =====
Revision                       Mean    Std Dev  N  Good?
chromium@425919                208737  1888.83  5  good
chromium@425924                209916  108.057  5  good
chromium@425925                210096  107.478  5  good
chromium@425925,v8@86d0dd362f  214706  131.512  5  bad    <--
chromium@425925,v8@cc07613674  212498  1879.01  5  bad
chromium@425925,v8@3145befb3d  213961  1621.84  5  bad
chromium@425926                214718  107.285  5  bad
chromium@425928                213965  1500.79  5  bad
chromium@425937                213898  1597.69  5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 657271

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_avg
Relative Change: 2.47%
Score: 95.0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/773
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998395421379668032


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5901028937957376

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment