Issue metadata
Sign in to add a comment
|
MacViews Harmony Page Info bubble is anchored too high. |
||||||||||||||||||||||||||||
Issue descriptionChrome 56.0.2894.0 OSX 10.11.6 What steps will reproduce the problem? (1) Enable #mac-views-webui-dialogs (MacViews) and #secondary-ui-md (Harmony) (2) Click on the Page Info bubble What is the expected output? The bubble is aligned with the bottom of the omnibox. See [1] for the Google-internal slide deck example. What do you see instead? The bubble extends into the omnibox (see screenshot). It seems that the [2] uses the same security indicator icon anchor (which is inside the omnibox), and assumes that it only needs to be placed 1px below. Found by ainslie@ during Material Page Info UI review. [1] https://docs.google.com/presentation/d/17CDjsa8u0rhgjV0zTCJMwY1z5BbaaXKiJqBL_N1s-9A/edit#slide=id.g160eef1b46_11_45 [2] https://chromium.googlesource.com/chromium/src/+/f6871304c12899a16a5931446c4cea8ec077f422/chrome/browser/ui/layout_constants.cc#48
,
Oct 20 2016
,
Nov 24 2016
,
Nov 24 2016
The very basic approach in https://codereview.chromium.org/2524223002/#ps1 gets pretty close. Just need to find the right padding constants now. Although there is one potential annoyance: the focus ring paints inside the omnibox. It even paints *over* the area of the location bar icon. This gives the perception of changing the alignment :/ I'll see what I can do to get it closer to the spec in Issue 566115 - these images are just the first pass.
,
Nov 24 2016
OK - I think I've got it right for most bubbles. ContentSettingsBubble isn't plumbed through correctly yet, but that's probably orthogonal. This is https://codereview.chromium.org/2524223002/#ps20001
,
Nov 25 2016
+hwi, +bettes
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e917fcdbb7701c1abc3c42d5d08ef8bf347b22ad commit e917fcdbb7701c1abc3c42d5d08ef8bf347b22ad Author: tapted <tapted@chromium.org> Date: Wed Nov 30 10:36:31 2016 MacViews: Anchor bubbles according to the MD spec. MD bubbles no longer use arrows. Instead the top outer-side corner of the bubble should align with the bottom outer-side corner of the location bar decoration. BUG= 657263 Review-Url: https://codereview.chromium.org/2524223002 Cr-Commit-Position: refs/heads/master@{#435206} [modify] https://crrev.com/e917fcdbb7701c1abc3c42d5d08ef8bf347b22ad/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field.mm [modify] https://crrev.com/e917fcdbb7701c1abc3c42d5d08ef8bf347b22ad/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h [modify] https://crrev.com/e917fcdbb7701c1abc3c42d5d08ef8bf347b22ad/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm [modify] https://crrev.com/e917fcdbb7701c1abc3c42d5d08ef8bf347b22ad/ui/views/bubble/bubble_border.cc
,
Feb 13 2017
,
Feb 13 2017
Ah, actually, it's "fine" - nothing shifted it, it just looks like it moves when there is/isn't a focus ring. So remaining things to do here: - fix content settings bubbles - shift it down the necessary amount -- bubbles with an anchor view are subject to LOCATION_BAR_BUBBLE_ANCHOR_VERTICAL_INSET, but on Mac we can't anchor to a view, so it's not in effect. * currently just page info, but also permissions bubbles after https://codereview.chromium.org/2693803002/ lands
,
Jun 27 2017
|
|||||||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Oct 19 2016147 KB
147 KB View Download