New issue
Advanced search Search tips

Issue 657261 link

Starred by 5 users
Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 588377
issue 657263
issue 706855
Blocking:
issue 657292


Show other hotlists

Hotlists containing this issue:
MacViews-Task-Queue


Sign in to add a comment

☂ MacViews Harmony Page Info bugs

Project Member Reported by lgar...@chromium.org, Oct 19 2016 
There are a bunch of Page Info UI polish bugs for Harmony (#secondary-ui-md) UI bugs that are specific to MacViews (#mac-views-webui-dialogs).
I'm collecting them all here because there aren't labels for both project parts.

Please feel free to generalize or de-dupe individual bugs if they turn out to affect other bubbles.

Comment 1 by lgar...@chromium.org, Oct 19 2016

Blockedon: 657263

Comment 2 by lgar...@chromium.org, Oct 19 2016

Blockedon: 588377

Comment 3 by lgar...@chromium.org, Oct 19 2016

Summary: ☂ MacViews Harmony Page Info bugs (was: ☂ MacViews Harmony UI polish bugs)
Changing the title to remove "polish", because some of these should block shipping Harmony on Mac.

Comment 4 by lgar...@chromium.org, Oct 19 2016

Blocking: 657292

Comment 5 by lafo...@chromium.org, Oct 20 2016

Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo

Comment 6 by elawrence@chromium.org, Mar 30 2017

Blockedon: 706855

Comment 7 by ellyjo...@chromium.org, Apr 12 2017

Labels: MacViews-Dialogs
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e784bbe3f972d69a37f6dcde35baa6a6b36468a6

commit e784bbe3f972d69a37f6dcde35baa6a6b36468a6
Author: Trent Apted <tapted@chromium.org>
Date: Fri Jul 28 05:48:53 2017

Remove some unnecessary page info bubble plumbing.

Code for showing the PageInfo bubble is currently plumbed through many
files unnecessarily.

This CL provides a single global entrypoint,
    bool ShowPageInfoDialog(content::WebContents* web_contents);
in chrome/browser/ui/page_info/page_info_dialog.h.

TBR=sky@chromium.org (refactoring fallout)

Bug:  657261 
Change-Id: I8fe25eab89f1bc349ed12688ce9d7a5e34c207db
Reviewed-on: https://chromium-review.googlesource.com/575795
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490289}
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/chromeos/login/ui/simple_web_view_dialog.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/autofill/chrome_autofill_client.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/browser_window.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/browser_dialogs_views_mac.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/browser_dialogs_views_mac.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/browser_window_cocoa.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/browser_window_cocoa.mm
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm
[add] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/page_info/page_info_dialog.cc
[add] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/page_info/page_info_dialog.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/frame/browser_view.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/location_bar/location_bar_view.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/location_bar/location_icon_view.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/browser/ui/views/toolbar/toolbar_view.h
[modify] https://crrev.com/e784bbe3f972d69a37f6dcde35baa6a6b36468a6/chrome/test/base/test_browser_window.h

Comment 9 by ellyjo...@chromium.org, Oct 4 2017

Status: Fixed (was: Available)
All bugs that this bug was blocked on are now fixed, so this bug is also fixed.
►

Sign in to add a comment