New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657254 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: Oct 2016
Cc:
█ hdodda@chromium.org
nyerramilli@chromium.org
█ tkonch...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: 'chrome://settings/searchEngines' page gets unresponsive after removing the search engine

Reported by dmascare...@etouch.net, Oct 19 2016 
Chrome Version:56.0.2894.1 (Official Build) dfd5c3c6083a3eb90daea1cd2215f139f20817f8-refs/branch-heads/2894@{#1}
OS: Windows(7,8,10), Mac (10.10.5,10.11.5)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/searchEngines
2. Click on iron icon of last search engine and then select 'Remove from list' 
3. Click on any iron icon or back arrow of the page and observe.

Actual: 'chrome://settings/searchEngines' page gets unresponsive after removing the search engine
Expected: Page should work properly.

This is regression issue, broken in 'M 56' and will soon update the manual bisect info:

Comment 1 by dmascare...@etouch.net, Oct 19 2016 

Manual bisect info:
Good build:56.0.2891.0
Bad build:56.0.2894.1
Actual_search.mp4
1.1 MB View Download

Comment 2 by hdodda@chromium.org, Oct 19 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision OS-Linux
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

Good Build: 56.0.2891.0(Revision : 425529)
Bad Build: 56.0.2894.1(Revision : 425838)

You are probably looking for a change made after 425533 (known good), but no later than 425534 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/4dbb42fe4765527a3f0ed359caac5f3dce7b1440..46b5ca1056271d70ed5e264612aafe9fa948a2a4

From the CL above, assigning the issue to the concern owner 

@dpapad - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2402553002

Note : Issue is seen in Linux OS also.

Thanks !

Comment 3 by dpa...@chromium.org, Oct 19 2016

Labels: Proj-MaterialDesign-WebUI

Comment 4 by dpa...@chromium.org, Oct 19 2016

Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9

commit 9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9
Author: dpapad <dpapad@chromium.org>
Date: Wed Oct 19 21:57:12 2016

MD Settings: Close action menu when search engine is removed.

BUG= 657254 , 633898 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://chromiumcodereview.appspot.com/2425423005
Cr-Commit-Position: refs/heads/master@{#426297}

[modify] https://crrev.com/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9/chrome/browser/resources/settings/search_engines_page/search_engine_entry.js
[modify] https://crrev.com/9d8c18b0b6e89c707733bc6fbac6a4195f8aedd9/chrome/test/data/webui/settings/search_engines_page_test.js

Comment 6 by dpa...@chromium.org, Oct 19 2016

Status: Fixed (was: Started)
►

Sign in to add a comment