New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657251 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cannot open the uber tray with touch screen when the "Autohide shelf" is enabled

Project Member Reported by satorux@chromium.org, Oct 19 2016

Issue description

Chrome Version       : 55.0.2883.7
OS Version: 8872.6.0
URLs (if applicable) :
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari 5:
  Firefox 4.x:
     IE 7/8/9:

What steps will reproduce the problem?
1. Enable "Autohide shelf" from the context menu on the shelf
2. Move the mouse cursor down to the bottom edge with *touch pad*
3. The shelf appears
4. Touch the shelf to open the launcher with *touch screen*

What is the expected result?

The launcher opens

What happens instead of that?

The shelf gets hidden


Please provide any additional information below. Attach a screenshot if
possible.

The same behaviors are observed if you try to touch other items on the shelf such as the uber tray and app icons.

Maybe a minor problem but it's a little annoying if you try to use touch pad and touch screen at the same time.


UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8872.6.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.7 Safari/537.36



 
Cc: omrilio@chromium.org
Components: UI>Shell>Shelf
+omrilio as FYI
Cc: -osh...@chromium.org tbuck...@chromium.org x...@chromium.org
Labels: -Pri-3 M-55 Pri-1
Owner: tdander...@chromium.org
Possibly some side effect of MD work?

I'm traveling and don't have a dev channel device handy.  If this is reproducible it should be a release blocker for 55.
Cc: dhadd...@chromium.org tdander...@chromium.org abodenha@chromium.org
Owner: abodenha@chromium.org
I tried the repro steps in #0 on 56.0.2888.0 canary minnie (with and without --ash-md=experimental) and on 54.0.2798 glimmer (with and without --ash-md=experimental). I observed the following in all cases:

* Touching the launcher will open the launcher as expected.
* Touching app icons in the shelf will launch or switch between apps as expected.
* Touching anything in the status tray area (system tray, notification center, etc) just hides the shelf and does not do what is expected.

This was reported for M-55 and should be checked in that version too (I don't have a build of M-55 handy). Since there is no change in behavior from M-54 to M-56, this is likely not a recent regression. This fact combined with the specific nature of the repro steps (you need to hover your cursor over an auto-hidden shelf and *then* touch it) I personally would not consider this to be a release blocker.

+dhaddock@ or Albert, can one of you try this out for an M-55 build and see if your findings are the same as mine?

Handing this back to Albert for next steps.

Comment 4 by x...@chromium.org, Oct 19 2016

I just tried on 56.0.2893.0 and the auto-hidden shelf works as expected. The launcher, app icons, notification button and the status tray all response as expected.
Tried again. This time, I was able to open the launcher, launch an app with touch. I still wasn't able to open the uber tray.

Forgot to mention that I'm using Pixel 2.


On M55 (8872.19.0 / 55.0.2883.22) minnie and samus:

I can open the launcher and apps with satorux@'s steps but I can't open the uber tray. With ash-md set to default or experimental 
This appears to be a side effect of mouse hide behavior.

When you hover over the tray it get's displayed, but then when the touch is detected the mouse is hidden causing the tray to be hidden at the same time it's processing the results of the touch.

I'd be very surprised if this is a new regression.  I'm seeing the same behavior in 54 that I see in 56.

Not sure the right solution here. Maybe avoid hiding the mouse in this case?
Cc: jennschen@chromium.org
Summary: Cannot open the uber tray with touch screen when the "Autohide shelf" is enabled (was: Cannot touch items on the shelf when "Autohide shelf" is enabled)
+jennschen as it sounds like a UX problem.
This seems like a bug to me — definitely not behavior by design.

• Touch should work even if the shelf is unhidden by mouse.

• Related bug: I also noticed that swiping the auto-hidden shelf up with touch doesn't auto-dismiss on blur (e.g. tapping on the window behind it). I noticed that the "auto hide" checkbox is actually disabled until you swipe it back down (or re-check it with the context menu), which is super confusing. Swiping the auto-hidden shelf in to view shouldn't disable the auto-hide toggle.
Labels: -Pri-1 -M-55 M-56 Pri-2
Right. Definitely a bug. We're just unclear on the right approach to fix it.

Hiding the mouse on touch + unhiding the shelf on mouse + touching the shelf implies a pile of contradictory signals flying back and forth at the same time. We can sort it out, but I worry about the result being brittle.

My preference would actually be to avoid hiding the mouse on touch (at least if the touch is on the shelf). I really don't see the value of hiding the mouse on touch in general, TBH.

As this is a long standing bug I'm going to drop to P2


Owner: omrilio@chromium.org
Owner: minch@chromium.org
Definitely
Status: Started (was: Assigned)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb9d1e0f123556d51169568a24042bb9a547031e

commit fb9d1e0f123556d51169568a24042bb9a547031e
Author: MinChen <minch@chromium.org>
Date: Mon Oct 09 17:51:15 2017

Keep shelf be shown if mouse cursor is in the shelf's bounds even if mouse events are disabled.

Bug:  657251 
Change-Id: Ia604cdc7658e7221bfe66004355a5b1211942c19
Reviewed-on: https://chromium-review.googlesource.com/706415
Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: min c <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507404}
[modify] https://crrev.com/fb9d1e0f123556d51169568a24042bb9a547031e/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/fb9d1e0f123556d51169568a24042bb9a547031e/ash/shelf/shelf_layout_manager_unittest.cc

Status: Fixed (was: Started)
Status: Assigned (was: Fixed)
Issue still reproducible on TOT 10115.0.0, 64.0.3264.0

1. Enable "Autohide shelf" from the context menu on the shelf
2. Move the mouse cursor down to the bottom edge with touchpad
3. The shelf appears
4. Touch the uber tray portion of shelf
5. Shelf gets hidden

Comment 18 by minch@chromium.org, Nov 11 2017

That's weird. Tried both on 64.3263.0.0 and tot 64.0.3265.0 according to the steps above,
device: kevin
can't repro the issue. Please check. Thanks.
Status: Verified (was: Assigned)
I reproduced the issue once again randomly on TOT 10124.0.0, 64.0.3265.0 today but not sure of the repro steps. Couldn't reproduce it again after that. 
Closing the bug as Verified. Will log a new bug with exact repro steps if seen again. Thanks!

Sign in to add a comment