Views Page Info should not shrink width with Harmony dropdowns |
||||||||
Issue descriptionChrome 55.0.2883.11 OSX 10.11.6 This doesn't happen in English, bug it can happen in another language. If you're using Harmony (#secondary-ui-md), then the bubble grows *and shrinks* its width depending on the longest string. After testing builds with various string lengths, I think it would be a better experience if the bubble never shrinks – only grows.
,
Oct 20 2016
,
Oct 20 2017
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 25 2017
+patricialor, can you verify if this is still an issue?
,
Nov 10 2017
,
Nov 15 2017
Yep, this behaviour is still an issue - I have a WIP to fix this here. https://chromium-review.googlesource.com/c/chromium/src/+/771050
,
Nov 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed10b0686bf7bb251375ddd0ff11c66c7cefeb21 commit ed10b0686bf7bb251375ddd0ff11c66c7cefeb21 Author: Patti <patricialor@chromium.org> Date: Thu Nov 16 02:37:38 2017 Desktop Page Info/Harmony: Never decrease the size of PageInfoBubbleView. The PageInfoBubbleView, when long strings are selected in its comboboxes, can sometimes expand its original size in Harmony mode. It will then shrink again if the long combobox option is changed back to a shorter one. This makes the UI move around a lot, so prevent it from getting smaller again. Bug: 657250 Change-Id: I49262900cc386ae2e57e02ba82a51cdae12e08a9 Reviewed-on: https://chromium-review.googlesource.com/771050 Reviewed-by: Lucas Garron <lgarron@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#516966} [modify] https://crrev.com/ed10b0686bf7bb251375ddd0ff11c66c7cefeb21/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
,
Nov 16 2017
,
Feb 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25cd20b5e89acf9fcc830799f9424cab1e226e15 commit 25cd20b5e89acf9fcc830799f9424cab1e226e15 Author: Patti <patricialor@chromium.org> Date: Thu Feb 01 00:55:46 2018 Revert "Desktop Page Info/Harmony: Never decrease the size of PageInfoBubbleView." This reverts commit ed10b0686bf7bb251375ddd0ff11c66c7cefeb21. Reason for revert: This causes crbug.com/795272 , but there isn't a good fix for this at the moment. Revert this as a workaround for now. Original change's description: > Desktop Page Info/Harmony: Never decrease the size of PageInfoBubbleView. > > The PageInfoBubbleView, when long strings are selected in its comboboxes, can > sometimes expand its original size in Harmony mode. It will then shrink again > if the long combobox option is changed back to a shorter one. This makes the UI > move around a lot, so prevent it from getting smaller again. > > Bug: 657250 > Change-Id: I49262900cc386ae2e57e02ba82a51cdae12e08a9 > Reviewed-on: https://chromium-review.googlesource.com/771050 > Reviewed-by: Lucas Garron <lgarron@chromium.org> > Commit-Queue: Patti <patricialor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#516966} TBR=lgarron@chromium.org,patricialor@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 657250, 795272 Change-Id: Ibbefa40b7dd32e1f69bdb04c4895594f053985a7 Reviewed-on: https://chromium-review.googlesource.com/894927 Reviewed-by: Patti <patricialor@chromium.org> Reviewed-by: Raymes Khoury <raymes@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#533497} [modify] https://crrev.com/25cd20b5e89acf9fcc830799f9424cab1e226e15/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
,
Feb 1 2018
,
Feb 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lgar...@chromium.org
, Oct 19 2016