MD Settings: Remove usage of 'autofocus' from settings-action-menu |
||||
Issue description'autofocus' is only respected on certain elements (form control elements), and not on any element, like paper-checkbox. Assigning 'autofocus' within showModal() is unnecessary, as well as keeping track of the currently focused index. It can be calculated on the fly, whenever the 'keydown' listener executes.
,
Oct 19 2016
,
Oct 21 2016
,
Oct 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9811dce8931bffbbdc9ae70e8e362491c3de4157 commit 9811dce8931bffbbdc9ae70e8e362491c3de4157 Author: dpapad <dpapad@chromium.org> Date: Tue Oct 25 02:39:10 2016 MD Settings: Remove usage of 'autofocus' from settings-action-menu. BUG= 657234 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2438423002 Cr-Commit-Position: refs/heads/master@{#427248} [modify] https://crrev.com/9811dce8931bffbbdc9ae70e8e362491c3de4157/chrome/browser/resources/settings/settings_action_menu.js [modify] https://crrev.com/9811dce8931bffbbdc9ae70e8e362491c3de4157/chrome/test/data/webui/settings/settings_action_menu_test.js
,
Oct 25 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dbeam@chromium.org
, Oct 19 2016