New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657231 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Sep 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug
Team-Security-UX

Blocked on:
issue 657230
issue 471390
issue 657225
issue 663975

Blocking:
issue 571533



Sign in to add a comment

Page Info Strings Cleanup

Project Member Reported by lgar...@chromium.org, Oct 19 2016

Issue description

We've had a bunch of Page Info string changes that leave us with technical debt.
I'm collecting them here.
 
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Blockedon: 663975
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666

commit fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666
Author: estark <estark@chromium.org>
Date: Mon Nov 14 02:17:29 2016

Add WebsiteSettings strings for malware/UwS/phishing

This CL shows appropriate security summary/description strings when a
page has been flagged as malware/social engineering/unwanted software.

Follow-up to https://codereview.chromium.org/2481743009/

Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as
a drive-by.

BUG= 646629 , 657231 
TEST=For each link under Webpage Warnings, repeat the following steps:
1. Visit http://testsafebrowsing.appspot.com in a new tab.
2. Follow the Webpage Warning link.
3. Click the "Dangerous" indicator in the omnibox.
4. Check that the following text appears:

phishing.html:
This site is deceptive
Attackers on this site may trick you into doing something dangerous like
installing software or revealing your personal information (for example,
passwords, phone numbers, or credit cards).

malware.html:
This site contains malware
Attackers on this site might attempt to install dangerous programs on
your computer that steal or delete your information (for example,
photos, passwords, messages, and credit cards).

unwanted.html:
This site contains harmful programs
Attackers on this site might try to trick you into installing programs
that harm your browsing experience (for example, by changing your
homepage or showing extra ads on sites you visit).

Review-Url: https://codereview.chromium.org/2497673002
Cr-Commit-Position: refs/heads/master@{#431818}

[modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/app/generated_resources.grd
[modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings.cc
[modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings.h
[modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings_ui.cc
[modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings_unittest.cc

Labels: -Hotlist-PageInfo
Components: -Security>UX

Comment 7 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt

Comment 8 by est...@chromium.org, Feb 18 2018

Labels: -Hotlist-EnamelAndFriendsFixIt
Status: Archived (was: Available)
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
Archiving old bugs that haven't been actively assigned in over 180 days.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!

Sign in to add a comment