Issue metadata
Sign in to add a comment
|
Page Info Strings Cleanup |
||||||||||||||||||||||||
Issue descriptionWe've had a bunch of Page Info string changes that leave us with technical debt. I'm collecting them here.
,
Oct 20 2016
,
Nov 11 2016
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666 commit fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666 Author: estark <estark@chromium.org> Date: Mon Nov 14 02:17:29 2016 Add WebsiteSettings strings for malware/UwS/phishing This CL shows appropriate security summary/description strings when a page has been flagged as malware/social engineering/unwanted software. Follow-up to https://codereview.chromium.org/2481743009/ Also removes unused string IDS_WEBSITE_SETTINGS_SECURE_TRANSPORT as a drive-by. BUG= 646629 , 657231 TEST=For each link under Webpage Warnings, repeat the following steps: 1. Visit http://testsafebrowsing.appspot.com in a new tab. 2. Follow the Webpage Warning link. 3. Click the "Dangerous" indicator in the omnibox. 4. Check that the following text appears: phishing.html: This site is deceptive Attackers on this site may trick you into doing something dangerous like installing software or revealing your personal information (for example, passwords, phone numbers, or credit cards). malware.html: This site contains malware Attackers on this site might attempt to install dangerous programs on your computer that steal or delete your information (for example, photos, passwords, messages, and credit cards). unwanted.html: This site contains harmful programs Attackers on this site might try to trick you into installing programs that harm your browsing experience (for example, by changing your homepage or showing extra ads on sites you visit). Review-Url: https://codereview.chromium.org/2497673002 Cr-Commit-Position: refs/heads/master@{#431818} [modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/app/generated_resources.grd [modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings.cc [modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings.h [modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings_ui.cc [modify] https://crrev.com/fcfccdb87b62d03ab73ad3557fdfe6b99bfc4666/chrome/browser/ui/website_settings/website_settings_unittest.cc
,
Nov 16 2016
,
Nov 30 2016
,
Nov 10 2017
,
Feb 18 2018
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
,
Sep 13
Archiving old bugs that haven't been actively assigned in over 180 days. If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks! |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Oct 19 2016