Page Info INSECURE_CONTENT_ERROR string is unused |
||||||||
Issue descriptionIDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_ERROR can only be triggered on mobile, except neither mobile platform allows active mixed We should remove the strings, and either remove the active mixed content flags, or DCHECK that they don't happen.
,
Oct 19 2016
,
Oct 20 2016
,
Nov 16 2016
,
Nov 30 2016
,
Nov 10 2017
,
Nov 30 2017
,
Dec 16 2017
Hi Igar, Using Code Search, I found the string defined at: https://cs.chromium.org/chromium/src/components/page_info_strings.grdp?type=cs&q=IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_ERROR&sq=package:chromium&l=93 and used at https://cs.chromium.org/chromium/src/chrome/browser/ui/page_info/page_info.cc?type=cs&q=IDS_PAGE_INFO_SECURITY_TAB_ENCRYPTED_INSECURE_CONTENT_ERROR&sq=package:chromium&l=254 . Should those two locations be removed? Thanks!
,
Feb 18 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lgar...@chromium.org
, Oct 19 2016