New issue
Advanced search Search tips

Issue 657215 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 614588



Sign in to add a comment

MD Settings: Manage passwords list is empty on first navigation.

Project Member Reported by dpa...@chromium.org, Oct 19 2016

Issue description

See attached screencast.

Repro steps: 
1) Launch chrome, go to chrome://md-settings
2) Click the advanced toggle and find the passwords section.
3) Observer that the list is empty.
4) Refresh the page. Now the list is populated.
 
manage_passwords.mp4
570 KB View Download
Labels: OS-Mac
Owner: hcarmona@chromium.org
Status: Assigned (was: Untriaged)
I was able to repro this on the mac canary, but only on first startup.

With a few minutes of investigation, it looks like the call to the passwords private api returns an empty list the first time it's called.

Comment 2 by dpa...@chromium.org, Oct 21 2016

Blocking: 614588

Comment 3 by dbeam@chromium.org, Oct 25 2016

Cc: rdevlin....@chromium.org
fwiw: it seems like there's a few solutions to this:

It looks like calling RespondLater() instead of RespondNow() from both GetSavedPasswordList and GetPasswordExceptionList in the API and using state in the delegate (i.e. is_initialized_ or simply set_password_{exception,}list_called_).

we may also be able to re-use the observers (and remove the getters if we can count on always getting an observation when registering).

also, see how the remove functions block on being initialized:
https://cs.chromium.org/chromium/src/chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.cc?sq=package:chromium&dr=CSs&rcl=1477408745&l=71

Comment 4 by dbeam@chromium.org, Oct 29 2016

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
i've looked into this a little bit, so i'll take it

Comment 5 by dbeam@chromium.org, Oct 31 2016

Status: Started (was: Assigned)

Comment 7 by dbeam@chromium.org, Nov 2 2016

Status: Fixed (was: Started)

Sign in to add a comment