New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657211 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Exit session button on public session is placed at wierd position on stylus-enabled device.

Project Member Reported by oka@chromium.org, Oct 19 2016

Issue description

Version: ToT
OS: Chrome OS kevin device.

What steps will reproduce the problem?
(1) Login to public session.
(2) Observe the right side of the system tray.

What is the expected output?
Exit session button should be positioned in the leftmost side.

What do you see instead?
The exit session button is positioned between the stylus icon and the notification icon.

 

Comment 1 by oka@chromium.org, Oct 19 2016

Cc: xiy...@chromium.org hirono@chromium.org zalcorn@chromium.org
Labels: M55 OS-Chrome
Hi xiyuan@.
Could you take a look at this issue? Thank you.

Comment 2 by oka@chromium.org, Oct 19 2016

Summary: Exit session button on public session is placed at wierd position on stylus-enabled device. (was: Exit session button on public session is placed at a wierd position on stylus-enabled device.)

Comment 3 by oka@chromium.org, Oct 19 2016

See the attached picture. The exit session button should be on the left of the stylus icon.
exit_session_actual.jpg
562 KB View Download

Comment 4 by hirono@chromium.org, Oct 19 2016

Cc: yoshiki@chromium.org

Comment 5 by xiy...@chromium.org, Oct 19 2016

Labels: -M55 M-55
The fix could be adjusting the creation order in StatusAreaWidget::CreateTrayViews, i.e. make the logout button created after all other buttons. [1] Since the bug is "started", I'll leave it to oka@.

Also noted the button height is wrong, which should be fixed in  issue 654803 . What is your chrome version?

[1] https://cs.chromium.org/chromium/src/ash/common/system/status_area_widget.cc?rcl=0&l=67

Comment 6 by oka@chromium.org, Oct 20 2016

I added you as a reviewer of the CL to fix the order. https://codereview.chromium.org/2427313003/.

Comment 7 by oka@chromium.org, Oct 20 2016

For the height, yes it's already fixed thanks to your CL.

Comment 8 by oka@chromium.org, Nov 7 2016

Labels: -Pri-1 Pri-2
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27f807d9af888c9db6236fd2adbb692112dcbd44

commit 27f807d9af888c9db6236fd2adbb692112dcbd44
Author: oka <oka@chromium.org>
Date: Fri Nov 11 02:06:11 2016

Move the 'Exit session' button to the most left side in the system tray.

BUG= 657211 
TEST=Using Linux,
- Launch chrome with --ash-enable-palette-on-all-displays --ash-enable-palette --login-manager flags.
- Login to public session.
- Enable on-screen keyboard.
- Observe that the exit session button is on the most left side in the system tray.
- Observe that the popup shown on clicking stylus icon is aligned with the icon.
  This is also confirmed on normal session.

Review-Url: https://codereview.chromium.org/2427313003
Cr-Commit-Position: refs/heads/master@{#431461}

[modify] https://crrev.com/27f807d9af888c9db6236fd2adbb692112dcbd44/ash/common/system/chromeos/palette/palette_tray.cc
[modify] https://crrev.com/27f807d9af888c9db6236fd2adbb692112dcbd44/ash/common/system/status_area_widget.cc

Comment 10 by oka@chromium.org, Nov 11 2016

Status: Fixed (was: Started)

Comment 11 by oka@chromium.org, Nov 11 2016

Labels: -M-55 M-56
Zach, let me know if this should be in M55.
56 is fine, thanks!
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26f5083f295844743f7e7510ba5fba5680368057

commit 26f5083f295844743f7e7510ba5fba5680368057
Author: yiyix <yiyix@chromium.org>
Date: Mon Dec 19 03:47:00 2016

Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position
in the status area widget, the logic on hiding separator of tray
in left of the |logout_button_tray_| is no longer needed because
there is no such tray. (confirmed with @sgabriel that
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG= 657211 

Review-Url: https://codereview.chromium.org/2582923002
Cr-Commit-Position: refs/heads/master@{#439398}

[modify] https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057/ash/common/system/status_area_widget.cc
[modify] https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057/ash/common/system/status_area_widget.h
[modify] https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/26f5083f295844743f7e7510ba5fba5680368057/ash/common/system/tray/tray_background_view.h

Cc: yiyix@chromium.org oka@chromium.org
Owner: tbuck...@chromium.org
Tom (or others), should https://codereview.chromium.org/2582923002 be merged to 56?
Labels: Merge-Request-56
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 9 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 11 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b51a93a49348dd8535737826dcef052d898cfbc

commit 4b51a93a49348dd8535737826dcef052d898cfbc
Author: Ben Ruthig <bruthig@chromium.org>
Date: Wed Jan 11 15:08:04 2017

Removing logic on showing/hiding separator

Since |logout_button_tray_| is moved to the left most position
in the status area widget, the logic on hiding separator of tray
in left of the |logout_button_tray_| is no longer needed because
there is no such tray. (confirmed with @sgabriel that
|logout_button_tray_| will always be the left most one).

Note that this is a partial revert of code added in
https://codereview.chromium.org/2147143002/.

BUG= 657211 

Review-Url: https://codereview.chromium.org/2582923002
Cr-Commit-Position: refs/heads/master@{#439398}
(cherry picked from commit 26f5083f295844743f7e7510ba5fba5680368057)

Review-Url: https://codereview.chromium.org/2627933002 .
Cr-Commit-Position: refs/branch-heads/2924@{#729}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/4b51a93a49348dd8535737826dcef052d898cfbc/ash/common/system/status_area_widget.cc
[modify] https://crrev.com/4b51a93a49348dd8535737826dcef052d898cfbc/ash/common/system/status_area_widget.h
[modify] https://crrev.com/4b51a93a49348dd8535737826dcef052d898cfbc/ash/common/system/tray/tray_background_view.cc
[modify] https://crrev.com/4b51a93a49348dd8535737826dcef052d898cfbc/ash/common/system/tray/tray_background_view.h

Cc: tbuck...@chromium.org dhadd...@chromium.org
Labels: Proj-MaterialDesign-CrOS
Owner: yiyix@chromium.org
Fix merged back into m-56, still requires verification (cc tbuckley@, dhaddock@).
Cc: krishna...@chromium.org
Krishna, can your team verify this public session bug is fixed? 
Cc: trapti@chromium.org
Components: Enterprise
Status: Verified (was: Fixed)
Verified in M56/Kevin.

The exit session button is on the left of the stylus icon.

Columns
M	ChromeOS	Chrome	ARC	Type	Channel
56	9000.67.0	56.0.2924.69	3650421	release	beta
Note:Verified for Public Session (#comment 22)

Sign in to add a comment