PushMessagingBrowserTest.SubscribeWorkerUsingManifest (run #1):
[ RUN      ] PushMessagingBrowserTest.SubscribeWorkerUsingManifest
[2557:2557:1018/155558:WARNING:chrome_browser_main_chromeos.cc(341)] Running as stub user with profile dir: test-user
[2557:2557:1018/155558:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
[2557:2557:1018/155558:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
Xlib:  extension "RANDR" missing on display ":9".
[2557:2617:1018/155558:ERROR:drive_integration_service.cc(120)] /tmp should have been created as clear.
[2557:2618:1018/155558:WARNING:local_extension_cache.cc(259)] Extensions will not be installed from update URLs until /tmp/.org.chromium.Chromium.MB31Av/d0KHvPY/stub_device_local_extension_cache/.initialized exists.
[2557:2620:1018/155558:WARNING:freezer_cgroup_process_manager.cc(59)] Cgroup freezer does not exist or is not writable. Unable to freeze renderer processes.
[2557:2591:1018/155558:WARNING:embedded_test_server.cc(201)] Request not handled. Returning 404: /favicon.ico
[2557:2557:1018/155558:INFO:CONSOLE(44)] "sendResultToTest: ok - service worker registered", source: https://127.0.0.1:47763/result_queue.js (44)
[2557:2557:1018/155558:INFO:CONSOLE(44)] "sendResultToTest: permission status - granted", source: https://127.0.0.1:47763/result_queue.js (44)
[2557:2557:1018/155558:INFO:CONSOLE(44)] "sendResultToTest: false - is not controlled", source: https://127.0.0.1:47763/result_queue.js (44)
../../chrome/browser/push_messaging/push_messaging_browsertest.cc:568: Failure
Value of: script_result
  Actual: "false - is not controlled"
Expected: "true - is controlled"
[2630:2630:1018/155558:ERROR:gles2_cmd_decoder.cc(16615)] [.DisplayCompositor-0x3472245caa00]GL ERROR :GL_INVALID_OPERATION : glCreateAndConsumeTextureCHROMIUM: invalid mailbox name
[2630:2630:1018/155558:ERROR:gles2_cmd_decoder.cc(9305)] [.DisplayCompositor-0x3472245caa00]RENDER WARNING: texture bound to texture unit 0 is not renderable. It maybe non-power-of-2 and have incompatible texture filtering.
[2557:2557:1018/155559:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[2557:2557:1018/155559:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[2557:2557:1018/155559:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown.
[  FAILED  ] PushMessagingBrowserTest.SubscribeWorkerUsingManifest, where TypeParam =  and GetParam() =  (1390 ms)

Disabling PushMessagingBrowserTest.SubscribeWorker and PushMessagingBrowserTest.SubscribeWorkerUsingManifest.
I can reproduce the flakiness locally, but I couldn't find when the flakiness started. On my machine I can reproduce the failure in builds from Oct 17.

 Issue 657333  has been merged into this issue.

 Issue 657227  has been merged into this issue.

Why would these tests begin to fail on just linux_chromium_chromeos_rel_ng? They're happy everywhere else, and they're important too :/.

The flakiness dashboard is also happy (modulo many-test asan flakes):

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests (with patch)&tests=PushMessagingBrowserTest.SubscribeWorker

I'll try to reproduce this locally as well, as Guido did in #3.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd1e162f9a246266115364256d7602aac2e3e9bf

commit bd1e162f9a246266115364256d7602aac2e3e9bf
Author: Guido Urdaneta <guidou@chromium.org>
Date: Wed Oct 19 12:13:56 2016

Disable flaky tests on Linux and ChromeOS.

The disabled tests are:
* BudgetManagerBrowserTest.BudgetInWorker
* PushMessagingBrowserTest.SubscribeWorker
* PushMessagingBrowserTest.SubscribeWorkerUsingManifest

BUG= 657202 
TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/2429263003 .

Cr-Commit-Position: refs/heads/master@{#426156}

[modify] https://crrev.com/bd1e162f9a246266115364256d7602aac2e3e9bf/chrome/browser/budget_service/budget_manager_browsertest.cc
[modify] https://crrev.com/bd1e162f9a246266115364256d7602aac2e3e9bf/chrome/browser/push_messaging/push_messaging_browsertest.cc

They are flaky on Linux too.
See https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests/builds/47817

 Issue 657354  has been merged into this issue.

 Issue 657371  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8062ec7de6c712190aad47f398f853afbfb19e5d

commit 8062ec7de6c712190aad47f398f853afbfb19e5d
Author: johnme <johnme@chromium.org>
Date: Tue Nov 01 14:15:45 2016

Fix flaky SW registration in PushMessaging/BudgetManager browser tests

There was a race condition between registering the Service Workers (and
having them install and activate) and reloading the page. Many tests
were assuming that reloading the page would be sufficient to ensure
the page was controlled by the Service Worker. This patch makes that
reliable, by waiting until the SW is ready.

It should fix the error mentioned in  https://crbug.com/657202 :
    Actual: "false - is not controlled"
  Expected: "true - is controlled"
which affected:
- BudgetManagerBrowserTest.BudgetInWorker
- PushMessagingBrowserTest.SubscribeWorker
- PushMessagingBrowserTest.SubscribeWorkerUsingManifest

Hopefully it'll also fix  https://crbug.com/554003  which affected:
- PushMessagingBrowserTest.SubscribePersiste
since the errors there were unclear but that test exercises SW
registration heavily, so it might well have suffered from the same
problem. If that test (alone) turns out to still be flaky, please just
mark it flaky again rather than reverting this patch.

BUG= 657202 , 554003 

Review-Url: https://codereview.chromium.org/2452833004
Cr-Commit-Position: refs/heads/master@{#428996}

[modify] https://crrev.com/8062ec7de6c712190aad47f398f853afbfb19e5d/chrome/browser/budget_service/budget_manager_browsertest.cc
[modify] https://crrev.com/8062ec7de6c712190aad47f398f853afbfb19e5d/chrome/browser/push_messaging/push_messaging_browsertest.cc
[modify] https://crrev.com/8062ec7de6c712190aad47f398f853afbfb19e5d/chrome/test/data/budget_service/budget_test.js
[modify] https://crrev.com/8062ec7de6c712190aad47f398f853afbfb19e5d/chrome/test/data/budget_service/service_worker.js
[modify] https://crrev.com/8062ec7de6c712190aad47f398f853afbfb19e5d/chrome/test/data/push_messaging/push_test.js
[modify] https://crrev.com/8062ec7de6c712190aad47f398f853afbfb19e5d/chrome/test/data/push_messaging/service_worker.js

There have been no flakes since this landed (which re-enabled the tests), so marking this as fixed.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests&tests=BudgetManagerBrowserTest.BudgetInWorker,PushMessagingBrowserTest.SubscribeWorker