New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657177 link

Starred by 0 users
Status: Fixed
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
█ wrengr@chromium.org
aarya@google.com
mbarbe...@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 644372



Sign in to add a comment

reorganize ProjectClassifier to be like ComponentClassifier

Project Member Reported by wrengr@chromium.org, Oct 18 2016 
A while back we refactored ComponentClassifier to have each Component know how to recognize themselves on the stack, and to remove the dependency on CrashConfig. We need to do the same thing with ProjectClassifier.

Also, we should make both of these classifiers more consistent about whether they return the most-suspected object(s) vs the string(s) naming those object(s).

Comment 1 by wrengr@chromium.org, Oct 18 2016

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 30 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/c6075535547c4e038d4466680d90479388581625

commit c6075535547c4e038d4466680d90479388581625
Author: katesonia <katesonia@chromium.org>
Date: Mon Jan 30 22:33:59 2017

[Predator] Add ``Project`` class and ``ClassifySuspect`` method to project classifier and component classifier.

Add ``Project`` class and ``ClassifySuspect`` method to project classifier and component classifier.

Also add validation for component classifier and project classifier.

N.B. Since I changed the config format of project classifier, so I included the validations in this cl.

BUG= 657177 ,  685448 
TBR=wrengr@chromium.org

Review-Url: https://codereview.chromium.org/2657913002

[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/component.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/component_classifier.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/findit_for_chromecrash.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/predator.py
[add] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/project.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/project_classifier.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/test/component_classifier_test.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/test/findit_for_chromecrash_test.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/test/predator_testcase.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/test/project_classifier_test.py
[add] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/crash/test/project_test.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/handlers/crash/crash_config.py
[add] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/handlers/crash/test/crash_config_test.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/libs/gitiles/change_log.py
[modify] https://crrev.com/c6075535547c4e038d4466680d90479388581625/appengine/findit/libs/gitiles/test/change_log_test.py

Comment 3 by st...@chromium.org, Apr 24 2017

Cc: -kateso...@chromium.org wrengr@chromium.org
Owner: kateso...@chromium.org

Comment 4 by st...@chromium.org, Apr 25 2017

Components: -Tools>Test>FindIt Tools>Test>Predator
Summary: reorganize ProjectClassifier to be like ComponentClassifier (was: [Findit] reorganize ProjectClassifier to be like ComponentClassifier)

Comment 5 by kateso...@chromium.org, May 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment