New issue
Advanced search Search tips

Issue 657172 link

Starred by 1 user
Status: Fixed
Owner:
zhangtiff@chromium.org
Closed: Oct 2016
Cc:
seanmccullough@chromium.org
zhangtiff@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

shouldn't be able to delete other people's comments

Project Member Reported by seanmccullough@google.com, Oct 18 2016 
An easy quick fix would be to only render the "X" button on the comment if the comment author is the same as the current user.

The current setup makes it too easy for the curious (or accident-prone) to click the X and delete someone else's comments.

Not a show stopper, and might even be a desirable feature in some cases.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/3f86933150a962d5d7326e175ecd9d6ada6f553f

commit 3f86933150a962d5d7326e175ecd9d6ada6f553f
Author: Tiffany Zhang <zhangtiff@google.com>
Date: Wed Oct 19 19:22:01 2016

SoM: Only delete your own comments.

BUG= 657172 

Change-Id: Ia7cc12ad2c00a6e17186c375a821c601ceb9fc6c
Reviewed-on: https://chromium-review.googlesource.com/400017
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/3f86933150a962d5d7326e175ecd9d6ada6f553f/go/src/infra/appengine/sheriff-o-matic/elements/som-annotations.html

Comment 2 by zhangtiff@chromium.org, Oct 19 2016

Status: Fixed (was: Available)
I think this should be good. :)
►

Sign in to add a comment