New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657171 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

USB audio volume spikes after suspend-resume

Project Member Reported by ka...@chromium.org, Oct 18 2016

Issue description

Just like  issue 520917 . Only with Plantronics USB headset(model Audio 655 DSP) - https://screenshot.googleplex.com/RAJjtWRR9mi.

After resume, the volume goes to high level(but not max).

M55 - 	8872.15.0 / 55.0.2883.17. Observed on samus and elm boards.

Does not repro with kip+ (rambi board), but it is evident for a part of a second before sound volume is corrected.

 

Comment 1 by ka...@chromium.org, Oct 18 2016

Labels: -Pri-3 Pri-2
The issue is consistent on the boards it is reproduced. 
With muted USB output, after resume mute is kept, but if you increase the volume it jumps to the high volume the bug results of.

Log is at https://pantheon.corp.google.com/storage/browser/chromiumos-test-logs/bugfiles/cr/657171/

Comment 2 by ka...@chromium.org, Oct 18 2016

Labels: -Pri-2 Pri-1

Comment 3 by hychao@chromium.org, Oct 19 2016

We need Yao-Wen's upstream patch https://patchwork.kernel.org/patch/7617961/ re-applied to kernel with versions < 4.4.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 19 2016

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/7cb46861a8b3a7a83dba411e998243eecc6c23d2

commit 7cb46861a8b3a7a83dba411e998243eecc6c23d2
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: I4de625ca61fcbb648130e8fc003cb253fcacf6ee
Reviewed-on: https://chromium-review.googlesource.com/400123
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/7cb46861a8b3a7a83dba411e998243eecc6c23d2/drivers/usb/core/quirks.c

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 19 2016

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/d5818af12a34d4e44c20b5837fb6cd230f5b5949

commit d5818af12a34d4e44c20b5837fb6cd230f5b5949
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Wed Oct 19 10:02:39 2016

Revert "CHROMIUM: USB: add reset resume quirk for some usb headsets."

This reverts commit 377864fb68d1f12d5ebbd739a8e9882b4eae4158.

An upstream commit will be cherry-picked to replace this one.

BUG= chromium:657171 
TEST=None

Change-Id: I20a7d97fee4b0e1654b999a8aea92b5bd793c0ad
Reviewed-on: https://chromium-review.googlesource.com/400282
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/d5818af12a34d4e44c20b5837fb6cd230f5b5949/drivers/usb/core/quirks.c

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/c77ea488184d6534daf0eaa6e0b3fc35cfe3eabb

commit c77ea488184d6534daf0eaa6e0b3fc35cfe3eabb
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: I8556ca472a93954e9ffd2b5e658e6762e7cc93ca
Reviewed-on: https://chromium-review.googlesource.com/400283
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/c77ea488184d6534daf0eaa6e0b3fc35cfe3eabb/drivers/usb/core/quirks.c

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 20 2016

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/aa05702f0b166b12d1e507229ddf28d9983ed2bd

commit aa05702f0b166b12d1e507229ddf28d9983ed2bd
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: Id466fc3f80d5cf60c6cef337c90a147b0aad4d41
Reviewed-on: https://chromium-review.googlesource.com/400164
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/aa05702f0b166b12d1e507229ddf28d9983ed2bd/drivers/usb/core/quirks.c

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 20 2016

Labels: merge-merged-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/b90e252faa4bae3b2d0187e310482c9a6305f5c9

commit b90e252faa4bae3b2d0187e310482c9a6305f5c9
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: I261485077598a6188deca60aabb97beb9517ceb3
Reviewed-on: https://chromium-review.googlesource.com/400124
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/b90e252faa4bae3b2d0187e310482c9a6305f5c9/drivers/usb/core/quirks.c

Comment 9 by hychao@chromium.org, Oct 21 2016

Labels: Merge-Request-55
Status: Started (was: Untriaged)

Comment 10 by dimu@chromium.org, Oct 21 2016

Labels: -Merge-Request-55 Merge-Approved-55 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M55 (branch: 2883)
Project Member

Comment 11 by bugdroid1@chromium.org, Oct 24 2016

Labels: merge-merged-release-R55-8872.B-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/1e8aebed58753a3a20cf5bfe0d84f8e77da870dd

commit 1e8aebed58753a3a20cf5bfe0d84f8e77da870dd
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: I4de625ca61fcbb648130e8fc003cb253fcacf6ee
Reviewed-on: https://chromium-review.googlesource.com/400123
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit 7cb46861a8b3a7a83dba411e998243eecc6c23d2)
Reviewed-on: https://chromium-review.googlesource.com/402129
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/1e8aebed58753a3a20cf5bfe0d84f8e77da870dd/drivers/usb/core/quirks.c

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 24 2016

Labels: merge-merged-release-R55-8872.B-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/a082694e562a665439185a0b8085ea0cc6468d69

commit a082694e562a665439185a0b8085ea0cc6468d69
Author: Hsin-Yu Chao <hychao@chromium.org>
Date: Wed Oct 19 10:02:39 2016

Revert "CHROMIUM: USB: add reset resume quirk for some usb headsets."

This reverts commit 377864fb68d1f12d5ebbd739a8e9882b4eae4158.

An upstream commit will be cherry-picked to replace this one.

BUG= chromium:657171 
TEST=None

Change-Id: I20a7d97fee4b0e1654b999a8aea92b5bd793c0ad
Reviewed-on: https://chromium-review.googlesource.com/400282
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit d5818af12a34d4e44c20b5837fb6cd230f5b5949)
Reviewed-on: https://chromium-review.googlesource.com/402130
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/a082694e562a665439185a0b8085ea0cc6468d69/drivers/usb/core/quirks.c

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 24 2016

Labels: merge-merged-release-R55-8872.B-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/18a34cbfb34fe41630db44b509f14b2a8c0097de

commit 18a34cbfb34fe41630db44b509f14b2a8c0097de
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: Id466fc3f80d5cf60c6cef337c90a147b0aad4d41
Reviewed-on: https://chromium-review.googlesource.com/400164
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit aa05702f0b166b12d1e507229ddf28d9983ed2bd)
Reviewed-on: https://chromium-review.googlesource.com/402132
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/18a34cbfb34fe41630db44b509f14b2a8c0097de/drivers/usb/core/quirks.c

Project Member

Comment 14 by bugdroid1@chromium.org, Oct 24 2016

Labels: merge-merged-release-R55-8872.B-chromeos-3.8
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/684e3a3a23ef1d3dd93afe4a97854088af4c436c

commit 684e3a3a23ef1d3dd93afe4a97854088af4c436c
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: I261485077598a6188deca60aabb97beb9517ceb3
Reviewed-on: https://chromium-review.googlesource.com/400124
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit b90e252faa4bae3b2d0187e310482c9a6305f5c9)
Reviewed-on: https://chromium-review.googlesource.com/402133
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/684e3a3a23ef1d3dd93afe4a97854088af4c436c/drivers/usb/core/quirks.c

Project Member

Comment 15 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/0977e78bee6c6968439217ecb18eb516c2ef2077

commit 0977e78bee6c6968439217ecb18eb516c2ef2077
Author: Yao-Wen Mao <yaowen@google.com>
Date: Mon Aug 31 06:24:09 2015

UPSTREAM: USB: Add reset-resume quirk for two Plantronics usb headphones.

These two headphones need a reset-resume quirk to properly resume to
original volume level.

Signed-off-by: Yao-Wen Mao <yaowen@google.com>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

BUG= chromium:657171 
TEST=Manual test Plantronics 655 DSP headset

Change-Id: I8556ca472a93954e9ffd2b5e658e6762e7cc93ca
Reviewed-on: https://chromium-review.googlesource.com/400283
Commit-Ready: Hsinyu Chao <hychao@chromium.org>
Tested-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
(cherry picked from commit c77ea488184d6534daf0eaa6e0b3fc35cfe3eabb)
Reviewed-on: https://chromium-review.googlesource.com/402131
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Commit-Queue: Hsinyu Chao <hychao@chromium.org>

[modify] https://crrev.com/0977e78bee6c6968439217ecb18eb516c2ef2077/drivers/usb/core/quirks.c

Labels: -Hotlist-Merge-Approved -Merge-Approved-55
Status: Fixed (was: Started)

Comment 17 by son...@google.com, Oct 26 2016

Status: Verified (was: Fixed)
Verified on build 8872.25.0

Sign in to add a comment