Update appearance of cros native scrollbars |
||||||
Issue descriptionWith --enable-overlay-scrollbar, Aura scrollbars should not consume layout space but should be overlayed on top of content instead. I suspect this isn't the case currently. In ScrollView::Layout we appear to be getting the scrollbar widths and subtracting them from viewport dimensions. When I added a NOTREACHED in NativeThemeAura for GetPartSize for non-thumb parts, I hit this stacktrace when a message box gets opened: #0 0x7fdb34023aae base::debug::StackTrace::StackTrace() #1 0x7fdb3409155f logging::LogMessage::~LogMessage() #2 0x7fdb29089a71 ui::NativeThemeAura::GetPartSize() #3 0x7fdb2808e85e views::NativeScrollBarWrapper::GetVerticalScrollBarWidth() #4 0x7fdb2808d875 views::NativeScrollBar::GetVerticalScrollBarWidth() #5 0x7fdb2808dc6c views::NativeScrollBar::GetLayoutSize() #6 0x7fdb28086359 views::ScrollView::GetScrollBarWidth() #7 0x7fdb28086a16 views::ScrollView::Layout() #8 0x7fdb28086071 views::ScrollView::SetHeaderOrContents() #9 0x7fdb28085f0e views::ScrollView::SetContents() #10 0x7fdb2807f889 views::MessageBoxView::ResetLayoutManager() #11 0x7fdb2807f339 views::MessageBoxView::Init() #12 0x7fdb2807f106 views::MessageBoxView::MessageBoxView()
,
Oct 24 2016
,
Oct 24 2016
I think for m56 we agreed to not have overlay scrollbars per se, but just to update the appearance of the non-overlay scrollbars.
,
Oct 24 2016
Yes, if they're overlay but have no animations, content will be obstructed.
,
Oct 24 2016
Issue 658776 has been merged into this issue.
,
Oct 24 2016
Tom, Sebastien, what's the scope for this change? 1. all native scrollbars on all Views platforms 2. all native scrollbars on ChromeOS 3. just the scrollbars in the system menu
,
Nov 5 2016
,
Nov 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/744d9b779a63b34bce18c0f2ef9206d4565af1ce commit 744d9b779a63b34bce18c0f2ef9206d4565af1ce Author: estade <estade@chromium.org> Date: Tue Nov 08 15:35:39 2016 Use overlay scrollbars for the cros system menu. These scrollbars are already used in the message center. These scrollbars are additionally applied to the CrOS system menu tray detail views (e.g. the list of wifi networks). At a later date, we can enhance these scrollbars (make sure they match Sebastien's specs) and generalize their use to more ChromeOS surfaces. Since it affects layout, we have to carefully make sure not to break anything. Depends on https://codereview.chromium.org/2480763005/ BUG= 657159 Review-Url: https://codereview.chromium.org/2478273003 Cr-Commit-Position: refs/heads/master@{#430619} [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ash/common/system/chromeos/ime_menu/ime_menu_tray.cc [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ash/common/system/tray/fixed_sized_scroll_view.cc [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ash/common/system/tray/fixed_sized_scroll_view.h [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ash/common/system/tray/tray_details_view.cc [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ui/views/controls/scrollbar/base_scroll_bar.h [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ui/views/controls/scrollbar/overlay_scroll_bar.cc [modify] https://crrev.com/744d9b779a63b34bce18c0f2ef9206d4565af1ce/ui/views/controls/scrollbar/overlay_scroll_bar.h
,
Nov 17 2016
this is fixed for the scroll bars we use in the system menu and notification center. The rest of the native scrollbars in chrome (e.g. bookmark folder editor, task manager, list of site cookies) are not updated, but those aren't part of system UI.
,
Nov 18 2016
Added a suggestion in bug 666798 .
,
Jan 30 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by tdander...@chromium.org
, Oct 20 2016