Note: for consistency with desktop, we should not color the summary.

Also note that "Re-enable warnings" is part of the security "Details" link on Page Info, so there's no need to implement that.

Well, we should color both for 56 ideally. Can we color both at the same time?

We intentionally punted on coloring for desktop because of technical complexity / technical debt. 

Yeah, I thought that was for 55. Is it fixable for 56? If not, we can punt even later. We should just keep them consistent.

Oh I see. I thought we wanted the updated strings for 55 so I got confused. Should this be split into two bugs?

There are two cases on Android which aren't possible on Desktop and so aren't covered by the doc above:

1) "content publisher" strings, for things like AMP pages

2) offline pages. These are meant to have an icon next to the summary string (which isn't working for me at the moment on Dev channel).

Do we have any idea for how to cover these cases?

Deleted: Screenshot_20161019-153503.png 974 KB

	Screenshot_20161019-153503.png 974 KB View Download

Deleted: Screenshot_20161019-153644.png 410 KB

	Screenshot_20161019-153644.png 410 KB View Download

Good question. For the time being we can probably leave the "detail" string as-is and not have a summary string. We can think more about what the summary should be.

I managed to get some implementation work done today, here are some screenshots.

The dialog now uses the same logic as desktop for determining what messages to display, so all of the strings should be identical to what is currently on desktop.

Deleted: Screenshot_20161020-154121.png 352 KB

	Screenshot_20161020-154121.png 352 KB View Download

Deleted: Screenshot_20161020-154132.png 188 KB

	Screenshot_20161020-154132.png 188 KB View Download

Deleted: Screenshot_20161020-154157.png 337 KB

	Screenshot_20161020-154157.png 337 KB View Download

Looks great!

By "same logic", do you mean the same C++ code, or parallel logic in Java?

The same C++ code is executed, and then the resulting strings are plumbed through to Java.

FYI the relevant ui-review thread is here (https://groups.google.com/a/google.com/forum/#!topic/chrome-ui-review/kodDJvduTKQ) -- specifically the Android mocks are on 9/21 and Alex said it looked good on 9/22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ec4b62739fca0380d6de17feb58d6f537983dbe

commit 7ec4b62739fca0380d6de17feb58d6f537983dbe
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Nov 03 23:44:17 2016

Android: Add connection security summary to page info popup

This adds a short summary message to the page info popup to explain the
security state of a page, along with the existing longer description.
These strings are now generated by the same C++ code which runs on
desktop, removing the need for most of the Android-specific strings and
logic.

BUG= 657148 

Review-Url: https://codereview.chromium.org/2468413002
Cr-Commit-Position: refs/heads/master@{#429729}

[modify] https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe/chrome/android/java/res/layout/website_settings.xml
[modify] https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
[modify] https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/7ec4b62739fca0380d6de17feb58d6f537983dbe/chrome/browser/ui/android/page_info/website_settings_popup_android.cc

maxwalker/emilyschechter: This has now rolled through to Canary/Dev channel on Android. Can you please take a look and check that this looks and functions as intended, so I can make any follow-up changes before M56 branches?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a

commit 6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a
Author: tsergeant <tsergeant@chromium.org>
Date: Fri Nov 11 00:20:07 2016

Android: Remove unnecessary members from WebsiteSettingsPopup

These were only used for a check to see if the current page was HTTPS,
which can be done more cleanly by checking the URL. This also fixes an
issue where the 'Details' link was not appearing correctly, due to a
change in the order of member initialization.

BUG= 657148 

Review-Url: https://codereview.chromium.org/2476533002
Cr-Commit-Position: refs/heads/master@{#431399}

[modify] https://crrev.com/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a/chrome/android/java/src/org/chromium/chrome/browser/pageinfo/WebsiteSettingsPopup.java
[modify] https://crrev.com/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a/chrome/android/java/src/org/chromium/chrome/browser/ssl/SecurityStateModel.java
[modify] https://crrev.com/6beda8f1ffcd4476d5304031aa18dfd7f3b7f01a/chrome/browser/ssl/security_state_model_android.cc

Marking this issue as fixed, any further changes that need to be made can go in a new bug.