New issue
Advanced search Search tips

Issue 657135 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 651993



Sign in to add a comment

Clean up ProfileIOData ownership of network objects.

Project Member Reported by mmenke@chromium.org, Oct 18 2016

Issue description

I recently fixed issue 651993, which was related to some network objects owned by the ProfileImplIOData being deleted URLRequests owned by the ProfileIOData.  While the immediate crash issue is fixed, there's still a lot of ugliness about who owns what here.  We should fix similar cases of this, and stick most network things ProfileIOData itself owns into its own URLRequestContextStorage object, to ensure a reasonable destruction order.

Long term, we may want to use URLRequestContextBuilder to create anything, but that's beyond the intended scope of this bug.
 

Comment 1 by mmenke@chromium.org, Oct 20 2016

Status: Fixed (was: Assigned)
Hrm...I did land https://chromiumcodereview.appspot.com/2428143002/, but there are fewer low hanging fruit in ProfileIOData than I thought - maybe 2-4 fields could be moved, don't think it's worth tackling the others.

Sign in to add a comment