ImageCapture: Implement getPhotoCapabilities()/setOptions() (Win) |
|||||||||||||||
Issue descriptionImplement ImageCapture's |brightness|, |contrast|, |saturation|, and |sharpness| [1,2] fields. [1] https://www.w3.org/TR/image-capture/#PhotoCapabilities [2] https://www.w3.org/TR/image-capture/#PhotoSettings
,
Oct 18 2016
,
Nov 23 2016
,
May 2 2017
,
May 3 2017
,
May 4 2017
Some screenshots of AmCap vs the implementation as it is being reviewed.
,
May 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4461e2b935fde482f530465ffdce34c75aff6d50 commit 4461e2b935fde482f530465ffdce34c75aff6d50 Author: mcasas <mcasas@chromium.org> Date: Sat May 06 19:18:21 2017 Image Capture: wire getCapabilities() in Windows This CL implements the GetPhotoCapabilities() method for Windows capture devices, by querying the appropriate ICameraControl- and IVideoProcAmp-supporting nodes of the |capture_filter_|. Screenshots of the produced results vs the AmCap provided values: https://ibb.co/cfhCwQ https://ibb.co/jNugqk https://ibb.co/feiwO5 https://ibb.co/kShZAk BUG= 657128 Review-Url: https://codereview.chromium.org/2856893003 Cr-Commit-Position: refs/heads/master@{#469879} [modify] https://crrev.com/4461e2b935fde482f530465ffdce34c75aff6d50/media/capture/video/win/video_capture_device_win.cc [modify] https://crrev.com/4461e2b935fde482f530465ffdce34c75aff6d50/media/capture/video/win/video_capture_device_win.h
,
May 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86adb2c88ba82194458ac09d078a00616c0b22dd commit 86adb2c88ba82194458ac09d078a00616c0b22dd Author: mcasas <mcasas@chromium.org> Date: Sat May 13 03:59:41 2017 Image Capture: wire setPhotoOptions() for Win This CL wires the photo capabilities setPhotoOptions() method: - |camera_control_| and |video_control_| are made member variables, which forces trivial updates to the lambdas. - most of the controls are straightforward except white balance and exposure: those have a 'manual' and 'auto' that enable the use of |color_temperature| and |exposure_compensation|, resp. Since either of them can be configured in subsequent setPhotoOptions() cycles, we need member flags to keep the manual/auto state. BUG= 657128 Review-Url: https://codereview.chromium.org/2873143002 Cr-Commit-Position: refs/heads/master@{#471554} [modify] https://crrev.com/86adb2c88ba82194458ac09d078a00616c0b22dd/media/capture/video/win/video_capture_device_win.cc [modify] https://crrev.com/86adb2c88ba82194458ac09d078a00616c0b22dd/media/capture/video/win/video_capture_device_win.h
,
May 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cd356540e646a136d9ac96c49920b0611227fc29 commit cd356540e646a136d9ac96c49920b0611227fc29 Author: mcasas <mcasas@chromium.org> Date: Sat May 13 04:16:55 2017 Revert of Image Capture: wire setPhotoOptions() for Win (patchset #3 id:80001 of https://codereview.chromium.org/2873143002/ ) Reason for revert: /video_capture_device_win.obj ninja -t msvc -e environment.x86 -- C:\b\c\goma_client/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\d3cb0e37bdd120ad0ac4650b674b09e81be45616\VC\bin\amd64_x86/cl.exe" /nologo /showIncludes /FC @obj/media/capture/capture_lib/video_capture_device_win.obj.rsp /c ../../media/capture/video/win/video_capture_device_win.cc /Foobj/media/capture/capture_lib/video_capture_device_win.obj /Fd"obj/media/capture/capture_lib_cc.pdb" c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(637): error C2220: warning treated as error - no 'object' file generated c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(637): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(644): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(654): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(661): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(670): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(676): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(681): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(686): warning C4189: 'hr': local variable is initialized but not referenced c:\b\c\b\win_chrome\src\media\capture\video\win\video_capture_device_win.cc(691): warning C4189: 'hr': local variable is initialized but not referenced Original issue's description: > Image Capture: wire setPhotoOptions() for Win > > This CL wires the photo capabilities setPhotoOptions() method: > > - |camera_control_| and |video_control_| are made member > variables, which forces trivial updates to the lambdas. > > - most of the controls are straightforward except white > balance and exposure: those have a 'manual' and 'auto' > that enable the use of |color_temperature| and > |exposure_compensation|, resp. Since either of them can > be configured in subsequent setPhotoOptions() cycles, we need > member flags to keep the manual/auto state. > > > > BUG= 657128 > > Review-Url: https://codereview.chromium.org/2873143002 > Cr-Commit-Position: refs/heads/master@{#471554} > Committed: https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a00616c0b22dd TBR=robliao@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 657128 Review-Url: https://codereview.chromium.org/2876303002 Cr-Commit-Position: refs/heads/master@{#471559} [modify] https://crrev.com/cd356540e646a136d9ac96c49920b0611227fc29/media/capture/video/win/video_capture_device_win.cc [modify] https://crrev.com/cd356540e646a136d9ac96c49920b0611227fc29/media/capture/video/win/video_capture_device_win.h
,
May 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bda7a4b1a6b2866538f903e06824500894d7d61 commit 7bda7a4b1a6b2866538f903e06824500894d7d61 Author: mcasas <mcasas@chromium.org> Date: Sun May 14 08:24:03 2017 RELAND: Image Capture: wire setPhotoOptions() for Win Original CL got reverted due to constructions like: if (bla) { HRESULT hr = foo(); DLOG_IF_FAILED_WITH_HRESULT("bla", hr) } which caused an error in the waterfall bots (not in the CQ) because of |hr| going unused. This CL corrects this. Original CL description ------------------------------------------------ This CL wires the photo capabilities setPhotoOptions() method: - |camera_control_| and |video_control_| are made member variables, which forces trivial updates to the lambdas. - most of the controls are straightforward except white balance and exposure: those have a 'manual' and 'auto' that enable the use of |color_temperature| and |exposure_compensation|, resp. Since either of them can be configured in subsequent setPhotoOptions() cycles, we need member flags to keep the manual/auto state. BUG= 657128 Review-Url: https://codereview.chromium.org/2873143002 Cr-Commit-Position: refs/heads/master@{#471554} Committed: https://chromium.googlesource.com/chromium/src/+/86adb2c88ba82194458ac09d078a00616c0b22dd patch from issue 2873143002 at patchset 80001 (http://crrev.com/2873143002#ps80001) TBR=robliao@chromium.org Review-Url: https://codereview.chromium.org/2884513002 Cr-Commit-Position: refs/heads/master@{#471623} [modify] https://crrev.com/7bda7a4b1a6b2866538f903e06824500894d7d61/media/capture/video/win/video_capture_device_win.cc [modify] https://crrev.com/7bda7a4b1a6b2866538f903e06824500894d7d61/media/capture/video/win/video_capture_device_win.h
,
May 15 2017
#10: Commit 7bda7a4b... initially landed in 60.0.3100.0 |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by mcasas@chromium.org
, Oct 18 2016