Issue 657127 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	steve...@chromium.org
Closed:	Nov 2016
Cc:	jamescook@chromium.org est...@chromium.org
Components:	UI>Shell>Networking
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
M-55

Eliminate ui/chromeos/network directory

Project Member Reported by steve...@chromium.org, Oct 18 2016

Issue description

In the Mash migration effort, having code in ui/chromeos/network is confusing, we should move it:

* ash/system (tray) code should move to ash/system/chromeos
* network_connect should move to chromeos/networork (with all UI delegated)
* network_state_notifier should move to chrome/browser/chromeos/net (for now)

Comment 1 by jamescook@chromium.org, Oct 18 2016

nit: system tray should move to //ash/common/system/chromeos

Plain-old ash/system will die shortly, as soon as we kill off the non-mash-compatible display manager bits.

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f42fb3550ed2e094542944712c7350736bc1b1a

commit 7f42fb3550ed2e094542944712c7350736bc1b1a
Author: stevenjb <stevenjb@chromium.org>
Date: Fri Oct 21 22:00:11 2016

Move NetworkStateNotifier and NetworkConnect from src/ui

This moves:
NetworkConnect -> src/chromeos
NetworkStateNotifier -> chrome/browser/chromeos/net

It also moves the following from chrome/browser/ui/ash to keep all
network UI code in the same place:
NetwrokConnectDelegateChromeos -> chrome/browser/chromeos/net

All UI code in NetworkConnect has been moved to NetworkConnect::Delegate.

BUG= 657127 

Review-Url: https://chromiumcodereview.appspot.com/2434683003
Cr-Commit-Position: refs/heads/master@{#426908}

[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ash/common/system/system_notifier.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ash/mus/network_connect_delegate_mus.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ash/mus/network_connect_delegate_mus.h
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ash/mus/window_manager_application.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/mobile/mobile_activator.cc
[rename] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/network_connect_delegate_chromeos.cc
[add] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/network_connect_delegate_chromeos.h
[rename] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/network_state_notifier.cc
[rename] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/network_state_notifier.h
[rename] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/network_state_notifier_unittest.cc
[add] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/shill_error.cc
[add] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/net/shill_error.h
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/options/vpn_config_view.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/options/wifi_config_view.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/options/wimax_config_view.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/status/data_promo_notification.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/status/data_promo_notification_unittest.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/extensions/api/networking_private/networking_private_ui_delegate_chromeos.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/08e9df3cf85451cac4cc82bafe816fa741b7a110/chrome/browser/ui/ash/network_connect_delegate_chromeos.h
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/ui/ash/vpn_delegate_chromeos.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chromeos/chromeos.gyp
[rename] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chromeos/network/network_connect.cc
[rename] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chromeos/network/network_connect.h
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chromeos/network/network_connection_handler.cc
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/chromeos/network/network_connection_handler.h
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/tools/gritsettings/resource_ids
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ui/chromeos/BUILD.gn
[modify] https://crrev.com/7f42fb3550ed2e094542944712c7350736bc1b1a/ui/chromeos/ui_chromeos_strings.grd

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c18469060e2a36d17e43298b249a7d255e60ef2f

commit c18469060e2a36d17e43298b249a7d255e60ef2f
Author: stevenjb <stevenjb@chromium.org>
Date: Mon Oct 24 22:09:32 2016

Move tray code from ui/chromeos/network/

Move remaining ui/chromeos/network code to to
ash/common/system/chromeos/network

This includes moving the associated resources to src/ash.

It also eliminates material_design_icon_controller.cc.

BUG= 657127 

Review-Url: https://codereview.chromium.org/2435903002
Cr-Commit-Position: refs/heads/master@{#427166}

[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/BUILD.gn
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/ash_chromeos_strings.grdp
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/material_design/material_design_controller.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/DEPS
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_icon.cc
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_icon.h
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_icon_animation.cc
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_icon_animation.h
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_icon_animation_observer.h
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_info.cc
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_info.h
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list.cc
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list.h
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list_delegate.h
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list_md.cc
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list_md.h
[add] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list_view_base.cc
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_list_view_base.h
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/network_state_list_detailed_view.h
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/tray_network.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/tray_network_state_observer.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/tray_vpn.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/vpn_list_view.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/common/system/chromeos/network/vpn_list_view.h
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/ash_resources.grd
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/notification_3g.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/notification_datasaver.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/notification_lte.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/status_captive_portal_access.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/status_cellular_failed.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/status_network_failed.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_1x.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_3g_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_3g_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_4g_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_4g_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_active_portal_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_arcs_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_arcs_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_bars_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_bars_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_edge_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_edge_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_evdo_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_evdo_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_gprs_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_gprs_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_hspa_plus_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_lte_advanced_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_lte_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_lte_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_roaming_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_roaming_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_secure_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_network_vpn_badge.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_vpn_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_100_percent/cros/network/statusbar_wired.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/notification_3g.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/notification_datasaver.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/notification_lte.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/status_captive_portal_access.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/status_cellular_failed.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/status_network_failed.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_3g_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_3g_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_4g_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_4g_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_active_portal_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_arcs_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_arcs_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_bars_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_bars_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_edge_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_edge_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_evdo_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_evdo_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_gprs_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_gprs_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_hspa_plus_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_lte_advanced_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_lte_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_lte_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_roaming_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_roaming_light.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_secure_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_network_vpn_badge.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_vpn_dark.png
[rename] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ash/resources/default_200_percent/cros/network/statusbar_wired.png
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/chrome/browser/chromeos/net/network_state_notifier.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/chrome/browser/chromeos/status/data_promo_notification.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/chrome/browser/chromeos/status/network_menu.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/chrome/browser/ui/webui/chromeos/login/network_dropdown.h
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ui/chromeos/BUILD.gn
[delete] https://crrev.com/ad04f7659e4451fbfa6e26a0b216a2ea1a39d009/ui/chromeos/material_design_icon_controller.cc
[delete] https://crrev.com/ad04f7659e4451fbfa6e26a0b216a2ea1a39d009/ui/chromeos/material_design_icon_controller.h
[delete] https://crrev.com/ad04f7659e4451fbfa6e26a0b216a2ea1a39d009/ui/chromeos/network/network_list_view_base.cc
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ui/chromeos/resources/ui_chromeos_resources.grd
[modify] https://crrev.com/c18469060e2a36d17e43298b249a7d255e60ef2f/ui/chromeos/ui_chromeos_strings.grd

Comment 4 by steve...@chromium.org, Nov 11 2016

Status: Fixed (was: Assigned)

Comment 5 by aashuto...@chromium.org, Dec 2 2016

Do we require any manual testing for verification?

Comment 6 by est...@chromium.org, Dec 2 2016

no, thanks for asking.

Comment 7 by aashuto...@chromium.org, Dec 6 2016

Status: Verified (was: Fixed)

Closing as verified.

►

Issue 657127 link

Issue metadata

Eliminate ui/chromeos/network directory

Issue description

Comment 1 by jamescook@chromium.org, Oct 18 2016

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Oct 21 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Oct 24 2016

Comment 3 Deleted

Comment 4 by steve...@chromium.org, Nov 11 2016

Comment 4 Deleted

Comment 5 by aashuto...@chromium.org, Dec 2 2016

Comment 5 Deleted

Comment 6 by est...@chromium.org, Dec 2 2016

Comment 6 Deleted

Comment 7 by aashuto...@chromium.org, Dec 6 2016

Comment 7 Deleted

Sign in to add a comment