Issue 657126 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	msw@chromium.org
Closed:	Oct 2016
Cc:	mustash-bugs@google.com
Components:	UI>Shell
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Proj-Mustash-Mash

Blocking:
issue 665179

Support volume accelerators in mash

Project Member Reported by msw@chromium.org, Oct 18 2016

Issue description

Support volume accelerators in mash

Chrome currently installs a VolumeControlDelegate for synchronous access.
We'll need to replace this with a mojo interface for volume control.

Project Member

Comment 1 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/67f43b078ce358d8b81ef120bfd13a07be8c6eed

commit 67f43b078ce358d8b81ef120bfd13a07be8c6eed
Author: msw <msw@chromium.org>
Date: Thu Oct 20 22:42:34 2016

Use mojo volume interfaces for mash and classic ash.

Add mojom::VolumeController; remove VolumeControlDelegate.
Make AccelleratorController connect to VolumeController.

Move UMA recording to ash, instead of Chrome.
Update unit tests; check UMA and accelerator history.
Move extension code to ExtensionSystemEventObserver.

BUG= 657126 
TEST=Automated; no Chrome OS volume button regressions.
R=jamescook@chromium.org,sky@chromium.org,dcheng@chromium.org

Review-Url: https://chromiumcodereview.appspot.com/2427913003
Cr-Commit-Position: refs/heads/master@{#426622}

[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/BUILD.gn
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/accelerators/accelerator_interactive_uitest_chromeos.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/accelerators/accelerator_controller.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/accelerators/accelerator_controller.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/system/audio/tray_audio.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/system/tray/default_system_tray_delegate.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/system/tray/default_system_tray_delegate.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/system/tray/system_tray_delegate.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/system/tray/system_tray_delegate.h
[delete] https://crrev.com/6c5be62748f4cd3036232ab6376feebb498fd16a/ash/common/system/volume_control_delegate.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/common/test/BUILD.gn
[delete] https://crrev.com/6c5be62748f4cd3036232ab6376feebb498fd16a/ash/common/test/test_volume_control_delegate.cc
[delete] https://crrev.com/6c5be62748f4cd3036232ab6376feebb498fd16a/ash/common/test/test_volume_control_delegate.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/mus/accelerators/accelerator_controller_unittest.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/public/interfaces/BUILD.gn
[add] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/public/interfaces/volume.mojom
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/app/mash/chrome_mash_content_browser_manifest_overlay.json
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chrome_content_browser_manifest_overlay.json
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chromeos/chrome_interface_factory.cc
[add] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chromeos/extensions/extension_volume_observer.cc
[add] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/chromeos/extensions/extension_volume_observer.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/ui/ash/system_tray_delegate_chromeos.h
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/ui/ash/volume_controller_browsertest_chromeos.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/ui/ash/volume_controller_chromeos.cc
[modify] https://crrev.com/67f43b078ce358d8b81ef120bfd13a07be8c6eed/chrome/browser/ui/ash/volume_controller_chromeos.h