New issue
Advanced search Search tips

Issue 657117 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Enable Blink developers to work with web-platform-tests instead of LayoutTests

Project Member Reported by foolip@chromium.org, Oct 18 2016

Issue description

This is an umbrella issue tracking the work described in this design doc:
https://docs.google.com/document/d/1JgPTyIWmjlXyhyatiZ9A6fSbUQPjCyM26budEY90VDE/edit?usp=sharing

It will result in infrastructure in need of long term ownership, but the scope of this issue is to reach the "Announce general availability of process on blink-dev" point.
 

Comment 1 by foolip@chromium.org, Oct 18 2016

Blockedon: 621599
Components: -Blink Blink>Infra
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d2957137905ad0dd4dd05669490def2f10312d9

commit 7d2957137905ad0dd4dd05669490def2f10312d9
Author: jeffcarp <jeffcarp@chromium.org>
Date: Thu Nov 10 18:57:52 2016

Remove whitespace from html/semantics/forms/the-input-element/radio.html

This is for testing the import and export scripts.

BUG= 657117 

Review-Url: https://codereview.chromium.org/2491133002
Cr-Commit-Position: refs/heads/master@{#431305}

[modify] https://crrev.com/7d2957137905ad0dd4dd05669490def2f10312d9/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/radio.html

Blocking: 666884
Blocking: 666861
Blocking: 666809
Blocking: -666809
Blockedon: 666809
Blockedon: 666861
Blocking: -666861
Blockedon: 666884
Blocking: -666884
Blockedon: 667975
Project Member

Comment 15 by bugdroid1@chromium.org, Nov 28 2016

Blockedon: 671890
Blockedon: 672215
Blockedon: 672536
Blockedon: 673814
jeffcarp@, https://codereview.chromium.org/2573773002/ had an exportable change hidden in third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual.html, can you see if your tools would have noticed, and can you export it?
Blockedon: 676399
Blockedon: 676426
Blockedon: 677669
Project Member

Comment 27 by bugdroid1@chromium.org, Dec 30 2016

Components: Blink>Infra>Predictability
Components: -Blink>Infra
Blockedon: 678806
Blockedon: 679084
Blockedon: 679091
Project Member

Comment 33 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64ea253d7b62b7a193f7ba9865e66b52174c98a8

commit 64ea253d7b62b7a193f7ba9865e66b52174c98a8
Author: jeffcarp <jeffcarp@chromium.org>
Date: Mon Jan 09 05:43:32 2017

[WPT Export] Delete remote branch, add label, additional refactoring

This CL

- Refactors TestExporter.run into 3 methods
- Has a number of other fixes to get things working
- Adds the `chromium-export` label to PRs after creation
- Deletes remote branch after uploading

(5/5) This CL succeeds https://codereview.chromium.org/2595143002 and is the last of the pipelined CLs broken out from https://codereview.chromium.org/2544173002.

BUG= 657117 , 676426 
R=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2608923002
Cr-Commit-Position: refs/heads/master@{#442198}

[modify] https://crrev.com/64ea253d7b62b7a193f7ba9865e66b52174c98a8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py
[modify] https://crrev.com/64ea253d7b62b7a193f7ba9865e66b52174c98a8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py
[modify] https://crrev.com/64ea253d7b62b7a193f7ba9865e66b52174c98a8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py
[modify] https://crrev.com/64ea253d7b62b7a193f7ba9865e66b52174c98a8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter_unittest.py
[modify] https://crrev.com/64ea253d7b62b7a193f7ba9865e66b52174c98a8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github.py
[modify] https://crrev.com/64ea253d7b62b7a193f7ba9865e66b52174c98a8/third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_github_mock.py

Blockedon: -679084
Blockedon: 679951
Blockedon: 679953
Blockedon: 679955
Blockedon: -679955
Blockedon: 682553
Blockedon: 682883
Blockedon: 684767
Blockedon: -682883
Blockedon: 685326
Blockedon: 686471
Blockedon: -686471
Blockedon: 689118
Blockedon: 693150
Project Member

Comment 50 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30

commit eda32ab0041fe3ca8ba09b4ef89f02bf90754e30
Author: foolip <foolip@chromium.org>
Date: Thu Feb 16 19:21:58 2017

Link to new web-platform-tests.org documentation from our own

Many pages of testthewebforward.org now redirect, so replace links with
something appropriate from the new documentation.

Since the new documentation consistently says "web-platform-tests"
instead of "Web Platform Tests" and this is what folks like jgraham tend
to write as well, align our own usage with that.

BUG= 657117 

Review-Url: https://codereview.chromium.org/2696323003
Cr-Commit-Position: refs/heads/master@{#451045}

[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/docs/testing/layout_tests.md
[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/docs/testing/layout_tests_tips.md
[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/docs/testing/layout_tests_with_manual_fallback.md
[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/docs/testing/web_platform_tests.md
[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/docs/testing/writing_layout_tests.md
[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/third_party/WebKit/Source/core/dom/custom/README.md
[modify] https://crrev.com/eda32ab0041fe3ca8ba09b4ef89f02bf90754e30/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier.py

Blockedon: 693350
Blockedon: 693351
Blockedon: 693821
Blockedon: 686471
Blockedon: 701147
Should we keep this bug open? I'm fine leaving it open as an ☔ issue but the main description, "Enable Blink developers to work with web-platform-tests instead of LayoutTests," has been accomplished.
I'd like to close this as fixed, but should the remaining open bugs be migrated to somewhere else? They weren't blocking the launch of wpt 2-way sync, it turns out :)
Agreed, I can migrate them to a new WPT Export 2.0/M2 umbrella issue.
Blockedon: -682553 -686471 -679951 -693821 -676399 -701147 -693150
Status: Fixed (was: Started)
Components: Blink>Infra>Ecosystem
Components: -Blink>Infra>Predictability

Sign in to add a comment