New issue
Advanced search Search tips

Issue 657116 link

Starred by 2 users
Status: Duplicate
Merged: issue 657115
Owner: ----
Closed: Dec 7
Cc:
eroman@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix NetLog callers that build a base::StringValue out of something not UTF8

Project Member Reported by eroman@chromium.org, Oct 18 2016 
Need to do a survey of callers and fix those that are possibly creating a base::StringValue out of something that isn't provably UTF8.

Doing some code searches these are the ones that seem suspicious and need more looking at:

NetLogSpdyGoAwayCallback -- “debug_data” -- https://cs.chromium.org/chromium/src/net/spdy/spdy_session.cc?rcl=0&l=242

ElideSpdyHeaderBlockForNetLog (look at callers of this) -- https://cs.chromium.org/chromium/src/net/http/http_log_util.cc?rcl=0&l=100

HttpRequestHeaders::NetLogCallback -- "line" -- https://cs.chromium.org/chromium/src/net/http/http_request_headers.cc?rcl=0&l=191

NetLogSimpleEntryCreationCallback -- "key" -- https://cs.chromium.org/chromium/src/net/disk_cache/simple/simple_net_log_parameters.cc?rcl=0&l=37

NetLogEntryCreationCallback -- "key" -- https://cs.chromium.org/chromium/src/net/disk_cache/memory/mem_entry_impl.cc?rcl=0&l=68

SdchManager::SdchInfoToValue -- “domain” -- https://cs.chromium.org/chromium/src/net/base/sdch_manager.cc?rcl=0&l=461

SdchManager::SdchInfoToValue -- “path” -- https://cs.chromium.org/chromium/src/net/base/sdch_manager.cc?rcl=0&l=462

NetLogSpdyPushPromiseReceivedCallback -- “headers” -- https://cs.chromium.org/chromium/src/net/spdy/spdy_session.cc?rcl=0&l=253

NetLogSpdyHeadersReceivedCallback -- “headers” -- https://cs.chromium.org/chromium/src/net/spdy/spdy_session.cc?rcl=0&l=97

NetLogSpdyHeadersSentCallback -- “headers” -- https://cs.chromium.org/chromium/src/net/spdy/spdy_session.cc?rcl=0&l=79

Comment 1 by eroman@chromium.org, Dec 7

Mergedinto: 657115
Status: Duplicate (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c72671df65fe642801408ec26c9c94a7f59049a

commit 5c72671df65fe642801408ec26c9c94a7f59049a
Author: Eric Roman <eroman@chromium.org>
Date: Thu Dec 13 23:42:57 2018

Escape FTP lines logged to NetLog which may not be UTF-8.

Bug:  657116 
Change-Id: I9b7eb9286b816f4ed993490c360f07e8b402ea9e
Reviewed-on: https://chromium-review.googlesource.com/c/1376989
Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#616494}
[modify] https://crrev.com/5c72671df65fe642801408ec26c9c94a7f59049a/net/ftp/ftp_ctrl_response_buffer.cc
►

Sign in to add a comment