New issue
Advanced search Search tips

Issue 657114 link

Starred by 2 users
Status: Fixed
Owner:
sergeyu@chromium.org
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

DCHECK in chromoting host when using WebRTC protocol

Project Member Reported by sergeyu@chromium.org, Oct 18 2016 
The following error is printed in the console:

#
# Fatal error in ../../third_party/webrtc/modules/desktop_capture/screen_capturer_x11.cc, line 235
# last system error: 11
# Check failed: !queue_.current_frame() || !queue_.current_frame()->IsShared()
# 
#
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3

commit 0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3
Author: sergeyu <sergeyu@chromium.org>
Date: Wed Oct 19 00:20:51 2016

Update WebrtcFrameScheduler to avoid concurrent captures.

Previously the scheduler would sometime schedule a new frame before the
previous frame is finished encoding. This was causing DCHECK in the
capturer and may lead to other unintended consequences.

BUG= 657114 

Review-Url: https://codereview.chromium.org/2431843002
Cr-Commit-Position: refs/heads/master@{#426102}

[modify] https://crrev.com/0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3/remoting/protocol/BUILD.gn
[modify] https://crrev.com/0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3/remoting/protocol/webrtc_dummy_video_encoder.h
[modify] https://crrev.com/0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3/remoting/protocol/webrtc_frame_scheduler_simple.cc
[modify] https://crrev.com/0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3/remoting/protocol/webrtc_frame_scheduler_simple.h
[add] https://crrev.com/0d63c67ff4554aaa7ba42a11ed33ef3880fe02d3/remoting/protocol/webrtc_frame_scheduler_unittest.cc

Comment 2 by sergeyu@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment