New issue
Advanced search Search tips

Issue 657101 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Refactor WorkletBackingThreadHolder with template pattern

Project Member Reported by hongchan@chromium.org, Oct 18 2016

Issue description

The current design of WorkletBackingThreadHolder has too many duplicated components. Refactor it with the template pattern.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6660c6d8bb364f1122c94db9f19a98f38b42a7a

commit b6660c6d8bb364f1122c94db9f19a98f38b42a7a
Author: hongchan <hongchan@chromium.org>
Date: Thu Oct 27 20:49:05 2016

Refactoring WorkletThreadBackingHolder with template pattern

The current design of WorkletBackingThreadHolder has too many duplicated
components. Refactor it with the template pattern.

BUG= 657101 
TEST=NONE (The CL passes AudioWorkletThread unit tests.)

Review-Url: https://codereview.chromium.org/2432543002
Cr-Commit-Position: refs/heads/master@{#428131}

[modify] https://crrev.com/b6660c6d8bb364f1122c94db9f19a98f38b42a7a/third_party/WebKit/Source/core/workers/BUILD.gn
[delete] https://crrev.com/65d0ad61589b3af49c0ae1655afc8c928a4c0b2d/third_party/WebKit/Source/core/workers/WorkletBackingThreadHolder.cpp
[delete] https://crrev.com/65d0ad61589b3af49c0ae1655afc8c928a4c0b2d/third_party/WebKit/Source/core/workers/WorkletBackingThreadHolder.h
[add] https://crrev.com/b6660c6d8bb364f1122c94db9f19a98f38b42a7a/third_party/WebKit/Source/core/workers/WorkletThreadHolder.h
[modify] https://crrev.com/b6660c6d8bb364f1122c94db9f19a98f38b42a7a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.cpp
[modify] https://crrev.com/b6660c6d8bb364f1122c94db9f19a98f38b42a7a/third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h
[modify] https://crrev.com/b6660c6d8bb364f1122c94db9f19a98f38b42a7a/third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp
[modify] https://crrev.com/b6660c6d8bb364f1122c94db9f19a98f38b42a7a/third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.h

Status: Verified (was: Started)

Sign in to add a comment