New issue
Advanced search Search tips

Issue 657093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

cleanup crazylinker code to support component build

Project Member Reported by michaelbai@chromium.org, Oct 18 2016

Issue description

Crazylinker's component build has been broken since Oct. 2013, but nobody cares about it. it seems that we don't need to support it in near future.

But, there are related code already broken, we should clean it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/275c325caaec3cc65f0c3be9af0abd00963e9d01

commit 275c325caaec3cc65f0c3be9af0abd00963e9d01
Author: michaelbai <michaelbai@chromium.org>
Date: Wed Oct 26 21:30:09 2016

Crazylinker: remove the code to load component build library

The code is broken, component build library will not be loaded if
non-component build library is in system lib path, e.g. Chrome is
preinstalled.

BUG= 657093 

Review-Url: https://codereview.chromium.org/2406083002
Cr-Commit-Position: refs/heads/master@{#427809}

[modify] https://crrev.com/275c325caaec3cc65f0c3be9af0abd00963e9d01/base/android/java/src/org/chromium/base/library_loader/Linker.java
[modify] https://crrev.com/275c325caaec3cc65f0c3be9af0abd00963e9d01/base/android/linker/config.gni

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e23b4d09d51ef90bfb50cf9763acc1ee2cd381f

commit 6e23b4d09d51ef90bfb50cf9763acc1ee2cd381f
Author: michaelbai <michaelbai@chromium.org>
Date: Thu Oct 27 16:55:37 2016

Revert of Crazylinker: remove the code to load component build library (patchset #4 id:60001 of https://codereview.chromium.org/2406083002/ )

Reason for revert:
Wrong change about comment

Original issue's description:
> Crazylinker: remove the code to load component build library
>
> The code is broken, component build library will not be loaded if
> non-component build library is in system lib path, e.g. Chrome is
> preinstalled.
>
> BUG= 657093 
>
> Committed: https://crrev.com/275c325caaec3cc65f0c3be9af0abd00963e9d01
> Cr-Commit-Position: refs/heads/master@{#427809}

TBR=torne@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 657093 

Review-Url: https://codereview.chromium.org/2453683007
Cr-Commit-Position: refs/heads/master@{#428059}

[modify] https://crrev.com/6e23b4d09d51ef90bfb50cf9763acc1ee2cd381f/base/android/java/src/org/chromium/base/library_loader/Linker.java
[modify] https://crrev.com/6e23b4d09d51ef90bfb50cf9763acc1ee2cd381f/base/android/linker/config.gni

Status: Fixed (was: Assigned)

Sign in to add a comment