[USS] Global metadata records in ModelTypeStore should be per model type |
|||
Issue descriptionIn current implementation records for ModelTypeState are stored in record with kGlobalMetadataKey key. It is not prefixed with model type which would cause issues when storing multiple model types in the same database. ModelTypeState record key should include model type prefix the same way data records do.
,
Nov 3 2016
,
Nov 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0 commit 89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0 Author: pavely <pavely@chromium.org> Date: Fri Nov 04 05:18:15 2016 [Sync] ModelTypeStore: Prepend global metadata key with model type prefix The issue is that two different model types sharing the same backend use the same key to store global metadata record. The fix is to add model type prefix to record key. R=maxbogue@chromium.org BUG= 657082 Review-Url: https://codereview.chromium.org/2468183005 Cr-Commit-Position: refs/heads/master@{#429791} [modify] https://crrev.com/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0/components/sync/model/model_type_store.cc [modify] https://crrev.com/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0/components/sync/model/model_type_store.h [modify] https://crrev.com/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0/components/sync/model/model_type_store_test_util.cc [modify] https://crrev.com/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0/components/sync/model_impl/model_type_store_impl.cc [modify] https://crrev.com/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0/components/sync/model_impl/model_type_store_impl.h [modify] https://crrev.com/89cc2c61dc9cd61a732b2f337c53fbf26c41fbe0/components/sync/model_impl/model_type_store_impl_unittest.cc
,
Nov 4 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by pav...@chromium.org
, Oct 18 2016