allow_csp_from-header.html is failing on Site Isolation FYI bots |
||
Issue descriptionThe failure started happening in this build: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/12033 This appears to be caused by https://codereview.chromium.org/2404373003, which introduced the test. amalika@, can you please take a look at why this test would fail with --site-per-process? To repro the failure: third_party/WebKit/Tools/Scripts/run-webkit-tests -v -t <output_dir> http/tests/security/contentSecurityPolicy/embeddedEnforcement/allow_csp_from-header.html --additional-drt-flag=--site-per-process --driver-logging --full-results-html Sample failing output from the test: CONSOLE ERROR: Refused to display 'http://localhost:8000/security/contentSecurityPolicy/resources/respond-with-allow-csp-from-header.php?allow_csp_from=&id=1' because it has not opted-into the following policy required by its embedder: 'script-src 'unsafe-inline'; img-src 'none''. CONSOLE ERROR: Refused to display 'http://localhost:8000/security/contentSecurityPolicy/resources/respond-with-allow-csp-from-header.php?allow_csp_from=*%20%C2%A2%C2%A5%C2%A7&id=3' because it has not opted-into the following policy required by its embedder: 'script-src 'unsafe-inline'; img-src 'none''. CONSOLE ERROR: line 26: Refused to load the image 'http://localhost:8000/security/contentSecurityPolicy/resources/green250x50.png' because it violates the following Content Security Policy directive: "img-src 'none'". CONSOLE ERROR: line 21: Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'nonce-123'". Either the 'unsafe-inline' keyword, a hash ('sha256-JpRGYTSWedsoA0c2YukDSHeYllz3+lVRTbtnDL79zi0='), or a nonce ('nonce-...') is required to enable inline execution. CONSOLE ERROR: Refused to display 'http://localhost:8000/security/contentSecurityPolicy/resources/respond-with-allow-csp-from-multiple-headers.php?allow_csp_from=&id=7' because it has not opted-into the following policy required by its embedder: 'script-src 'unsafe-inline'; img-src 'none''. CONSOLE ERROR: line 26: Refused to load the image 'http://localhost:8000/security/contentSecurityPolicy/resources/green250x50.png' because it violates the following Content Security Policy directive: "img-src 'none'". CONSOLE ERROR: line 26: Refused to load the image 'http://127.0.0.1:8000/security/contentSecurityPolicy/resources/green250x50.png' because it violates the following Content Security Policy directive: "img-src 'none'". This is a testharness.js-based test. PASS Same origin iframes are always allowed. PASS Cross origin iframe with requiredCSP but without Allow-CSP-From header gets blocked. PASS iframe from cross origin does not load without Allow-CSP-From header. PASS Iframe with improper Allow-CSP-From header gets blocked. PASS Star Allow-CSP-From header can be returned. PASS Allow-CSP-From header enforces EmbeddingCSP. FAIL Star Allow-CSP-From header allows the parent to enforce its Embedding CSP. assert_equals: expected 20 but got 26 FAIL Only first Allow-CSP-From header is considered. assert_unreached: No message should be sent from the frame. Reached unreachable code Harness: the test ran to completion. (A tip is to include linux_site_isolation in tryjobs for CLs that might affect OOPIF behavior; it runs all layout tests with --site-per-process and would've likely caught this.)
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ffd0c9861f0a04be58333ce02a1a588dba99319e commit ffd0c9861f0a04be58333ce02a1a588dba99319e Author: amalika <amalika@google.com> Date: Thu Oct 20 10:27:11 2016 Fixing allow_csp_from.html test and enabling it back in sit-per-process BUG= 657081 Review-Url: https://chromiumcodereview.appspot.com/2431353002 Cr-Commit-Position: refs/heads/master@{#426444} [modify] https://crrev.com/ffd0c9861f0a04be58333ce02a1a588dba99319e/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process [modify] https://crrev.com/ffd0c9861f0a04be58333ce02a1a588dba99319e/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/allow_csp_from-header.html [modify] https://crrev.com/ffd0c9861f0a04be58333ce02a1a588dba99319e/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/child-csp-test.js [modify] https://crrev.com/ffd0c9861f0a04be58333ce02a1a588dba99319e/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/resources/respond-with-allow-csp-from-multiple-headers.php
,
Nov 2 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Oct 18 2016