New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 657067 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

MD OOBE breaks enterprise enrollment.

Project Member Reported by tnagel@chromium.org, Oct 18 2016

Issue description

Filing a separate blocker bug to ensure we don't ship a broken build to dev channel.

See also  issue 604119 .
 
Could you explain what doesn't work?
I was able to successfully enroll device with new OOBE.

Comment 2 by tnagel@chromium.org, Oct 25 2016

Sorry for not providing repro steps.  (The repro case seems to be narrower than I had initially assumed.)

Steps to repro (tested with today's ToT 4b52d653d510):
1. Create chrome_os build on Linux.
2. Run "chrome --user-data-dir=/tmp/$RANDOM-$RANDOM --login-manager --login-profile=user"
3. On the very first screen, hit Ctrl-Alt-E.
4. Continue to enrollment screen and try to enroll.
5. Enrollment fails.
6. Try again to enroll.
7. Chrome crashes.


[989:989:1025/140558:FATAL:enterprise_enrollment_helper_impl.cc(163)] Check failed: dcp_initializer. 
#0 0x7fb0bbda6c2e base::debug::StackTrace::StackTrace()
#1 0x7fb0bbdc1a6a logging::LogMessage::~LogMessage()
#2 0x7fb0bc8acebf chromeos::EnterpriseEnrollmentHelperImpl::DoEnroll()
#3 0x7fb0bc9725b4 policy::(anonymous namespace)::PolicyOAuth2TokenFetcherImpl::OnGetTokenSuccess()
#4 0x7fb0bc554701 OAuth2AccessTokenFetcherImpl::EndGetAccessToken()
#5 0x7fb0bc554b79 OAuth2AccessTokenFetcherImpl::OnURLFetchComplete()
#6 0x7fb0bbda7733 base::debug::TaskAnnotator::RunTask()
#7 0x7fb0bbdc9f7c base::MessageLoop::RunTask()
#8 0x7fb0bbdca298 base::MessageLoop::DeferOrRunPendingTask()
#9 0x7fb0bbdca65b base::MessageLoop::DoWork()
#10 0x7fb0bbdcbcaa base::(anonymous namespace)::WorkSourceDispatch()
#11 0x7fb0b551ae04 g_main_context_dispatch
#12 0x7fb0b551b048 <unknown>
#13 0x7fb0b551b0ec g_main_context_iteration
#14 0x7fb0bbdcbb16 base::MessagePumpGlib::Run()
#15 0x7fb0bbdc9d28 base::MessageLoop::RunHandler()
#16 0x7fb0bbdee9e0 base::RunLoop::Run()
#17 0x7fb0bcc0538e ChromeBrowserMainParts::MainMessageLoopRun()
#18 0x7fb0b98a4c99 content::BrowserMainLoop::RunMainMessageLoopParts()
#19 0x7fb0b98a79cd content::BrowserMainRunnerImpl::Run()
#20 0x7fb0b98a099e content::BrowserMain()
#21 0x7fb0b9e1ff24 content::ContentMainRunnerImpl::Run()
#22 0x7fb0b9e1eb00 content::ContentMain()
#23 0x7fb0bc53ccc3 ChromeMain
#24 0x7fb0b30f2f45 __libc_start_main
#25 0x7fb0bc53cb61 <unknown>
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Enterprise bugs don't generally block Dev channel.  Moving this to Beta blocking unless someone has a strong opinion otherwise.

Thiemo, can you clarify how this bug affects release builds of Chrome OS?
I just tried to do this and it works (in ToT 56.0.2900.0).
I also tried to do this on a device, and succeeded.

What am I doing wrong?

Comment 5 by tnagel@chromium.org, Oct 26 2016

Katherine, I guess blocking beta instead of dev is fine since there there is an easy workaround / it seems hard to repro the issue.

Alexander, did you hit Ctrl-Alt-E on the very first screen?  The one with the Chromebook and the ladder and the window cleaner?
Status: Started (was: Assigned)
I can reproduce it.
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f434d8fccde85c49e6310cf483d058b0be783d12

commit f434d8fccde85c49e6310cf483d058b0be783d12
Author: alemate <alemate@chromium.org>
Date: Fri Oct 28 19:15:45 2016

ChromeOS MD-OOBE: Disable duplicate 'connected' events.

This CL fixes the problem with duplicate 'connected' events that get
acynchronously delivered to the wrong screen.

BUG= 657067 
TEST=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2459603003
Cr-Commit-Position: refs/heads/master@{#428456}

[modify] https://crrev.com/f434d8fccde85c49e6310cf483d058b0be783d12/chrome/browser/resources/chromeos/login/oobe_welcome.js

Status: Fixed (was: Started)

Comment 9 Deleted

Comment 10 by trapti@google.com, Nov 1 2016

Typo in previous comment.Tested in latest M56.

Could not repro on latest M56. Marking as Verified.

Tried Ctrl-Alt-E on the very first screen and enrolling.

Peppy

 
Columns
M	ChromeOS	Chrome	ARC	Type	Channel
56	8953.0.0	56.0.2905.0	3422604	release	dev
Confirming verified.  Thank you, Sasha!

Sign in to add a comment