DCHECK in NTPSnippetsService::GetCategoryStatus: unregistered category |
||||
Issue description[FATAL:ntp_snippets_service.cc(308)] Check failed: base::ContainsKey(categories_, category) Repro: 1. Load the NTP with multiple sections. 2. Ensure you have articles and debug sections 3. Sign in (or sign out) => Crash NTPSnippetsService::NukeAllSnippets() remove all the categories, but for some reason ContentSuggestionsService::GetCategories returns more categories than expected (I can log [2, 10001, 10002]). When the front end queries for the status of 10002, we get a crash because the snippets service does not have this category anymore.
,
Oct 20 2016
Huh, I had to explicitly refresh the NTP to trigger this - that should happen automatically on sign-out. Yet another bug?
,
Oct 20 2016
We currently only refresh the category for which we received a sign out status change, not the whole NTP. I don't really remember the rationale for that. I think something like "bookmarks are not cleared when you sign out". But even if we refresh the bookmark section should follow the bookmark manager behaviour so... bug maybe yes.
,
Oct 20 2016
Found it. Bad news: It's an actual bug, and it's already in M55. Good news: As far as I can tell, it shouldn't be a big issue - at worst, the supposedly nuked category might show up again (empty).
,
Oct 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/534523ba36742819e3712ae9054705b431e20d37 commit 534523ba36742819e3712ae9054705b431e20d37 Author: treib <treib@chromium.org> Date: Thu Oct 20 16:19:44 2016 [NTP Snippets] NTPSnippetsService: notify about new suggestions only in changed categories BUG= 657038 Review-Url: https://chromiumcodereview.appspot.com/2438543003 Cr-Commit-Position: refs/heads/master@{#426492} [modify] https://crrev.com/534523ba36742819e3712ae9054705b431e20d37/components/ntp_snippets/content_suggestions_service.cc [modify] https://crrev.com/534523ba36742819e3712ae9054705b431e20d37/components/ntp_snippets/remote/ntp_snippets_service.cc [modify] https://crrev.com/534523ba36742819e3712ae9054705b431e20d37/components/ntp_snippets/remote/ntp_snippets_service.h
,
Oct 20 2016
Re comment 2/3: Seems to be a different bug; I filed issue 657936.
,
Oct 24 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dgn@chromium.org
, Oct 18 2016