New issue
Advanced search Search tips

Issue 657016 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

LogDog should cache log stream parameters.

Project Member Reported by d...@chromium.org, Oct 18 2016

Issue description

Currently, LogDog Coordinator log stream operations do not perform any caching. Enable basic memcache-based caching for the Coordinator and integrate it into obvious places.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/36e46653dea3598592b8913583273107c472b540

commit 36e46653dea3598592b8913583273107c472b540
Author: dnj <dnj@chromium.org>
Date: Thu Oct 27 03:35:47 2016

LogDog: Add Storage-layer data caching.

This adds a generic Storage caching system and a memcache implementation
in the Coordinator application.

It also integrates that caching into two Storage subsystems:
- For BigTable-based Storage, the last "Tail" cursor is cached to
  speed up subsequent Tail operations.
- For Archive-based Storage, the log's index is cached to speed up
  subsequent log accesses.

This switches over "endpoints" Get test to use a memory-backed BigTable
implementation instead of a pure memory intermediate storage instance.
This exercises more of the real production code paths during gets,
including the new caching path.

TBR=nodir@chromium.org
BUG= chromium:657016 
TEST=None

Review-Url: https://codereview.chromium.org/2435113002

[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/coordinatorTest/context.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/coordinatorTest/service.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/coordinatorTest/storage_cache.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/endpoints/logs/get.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/endpoints/logs/get_test.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/service.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/storage_cache.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/appengine/coordinator/storage_cache_test.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/archive/cache.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/archive/storage.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/archive/storage_test.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/bigtable.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/bigtable_test.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/cache.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/initialize.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/storage.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/storage_test.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/bigtable/testing.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/caching/cache.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/caching/doc.go
[add] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/memory/cache.go
[modify] https://crrev.com/36e46653dea3598592b8913583273107c472b540/logdog/common/storage/memory/memory.go

Comment 2 by d...@chromium.org, Oct 27 2016

Status: Fixed (was: Started)
This should be fixed now

Sign in to add a comment