New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 657010 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Oct 2016
Cc:
█ sureshkumari@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Empty omniibox after search in new tab

Reported by mynameis...@gmail.com, Oct 18 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 YaBrowser/16.10.0.2260 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
1. Apply patch included
2. Switch to Avera SafeSearch
3. Type something in page search bar
4. Hit enter

What is the expected behavior?
Omnibox shows search string

What went wrong?
Omnibox is empty.

Did this work before? N/A 

Chrome version: 54.0.2840.0  Channel: stable
OS Version: 
Flash Version: Shockwave Flash 22.0 r0

Possible fix is to clear virtual_url_ 
field in navigation_controller_impl::RendererDidNavigateToNewPage. This worked in previous versions and bug appeared because the order of comparision changed a little bit.
avira_safe_search (1).patch
4.9 KB Download

Comment 1 by sureshkumari@chromium.org, Oct 19 2016

Cc: sureshkumari@chromium.org
Labels: Needs-Feedback OS-Linux OS-Mac
Unable to reproduce the issue on windows-7, windows-10, Mac- 10.11.4 and ubuntu 14.04 using chrome stable version 54.0.2840.59 and Latest canary 56.0.2895.0 with following steps
1.opened chrome
2.Added Avera SafeSearch to chrome from webstore
3.Typed search string in page search box
4.Got the search results and observed that Omnibox shows search string

please find the attached screencast and let us know if anything missed here.Also please eloborate step 1 to add Avira patch or provide us any json file to add extension.

Thanks,
657010.mp4
773 KB View Download

Comment 2 by mynameis...@gmail.com, Oct 19 2016 

Hi.
You added Avira Safe search via store but in this case it works. It's only broken when it's added in prepopulated engines. And we are going to push such changes to upstream, so it's important. Try applying the patch I attached please.

Comment 3 by jmukthavaram@chromium.org, Oct 20 2016

Labels: TE-NeedsTriageHelp
Could someone from Omnibox team look into this issue.

Thank you.

Comment 4 by meh...@chromium.org, Oct 20 2016

Components: -UI UI>Browser>Omnibox

Comment 5 by pkasting@chromium.org, Oct 20 2016

Status: WontFix (was: Unconfirmed)
If something is broken with a custom patch applied, it's by definition not a bug in the existing source tree and thus not suitable for the bug tracker.

If you want to land a custom patch, go through the normal steps of putting it up for review, and then note whatever unsolvable problems you have with it and see if you can get help at that time.

Note that changes to Chrome's prepopulated search engines have legal ramifications, so patches to add or change engines are rarely accepted.  If you want to ship your own fork that makes these changes, then you're also on your own for fixing any bugs with them.
►

Sign in to add a comment