New issue
Advanced search Search tips

Issue 656992 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
TT



Sign in to add a comment

Adding AD accounts/users to Chrome OS

Project Member Reported by rsorokin@chromium.org, Oct 18 2016

Issue description

More information coming

 
Labels: Chromad
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02

commit 3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02
Author: alemate <alemate@chromium.org>
Date: Thu Oct 27 19:05:12 2016

ChromeOS: This CL moves chromeos/login/user_names* to user_mananger.

We need to use ChromeOS reserved user_names in user_manager, so
I am moving it to components.user_manager.

BUG=462823, 656992 
TEST=none

Review-Url: https://codereview.chromium.org/2452983002
Cr-Commit-Position: refs/heads/master@{#428103}

[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/arc/arc_auth_service_unittest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/extensions/users_private/users_private_api.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/demo_mode/demo_app_launcher.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/ui/webui_login_display.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/users/chrome_user_manager_util.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/users/supervised_user_manager_impl.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/policy/device_local_account.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/chromeos/policy/power_policy_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/drive/drive_notification_manager_factory_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_apitest_nss.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/extensions/extension_garbage_collector_chromeos_unittest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/invalidation/profile_invalidation_provider_factory_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/profiles/profile_manager_unittest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/signin/easy_unlock_service_regular.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/ui/app_list/app_list_controller_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/ui/webui/options/chromeos/accounts_options_handler.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/ui/webui/options/chromeos/guest_mode_options_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chrome/browser/ui/webui/options/chromeos/guest_mode_options_ui_browsertest.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chromeos/chromeos.gyp
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chromeos/login/auth/login_performer.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/chromeos/login/auth/user_context.cc
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/components/user_manager/BUILD.gn
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/components/user_manager/DEPS
[modify] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/components/user_manager/fake_user_manager.cc
[rename] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/components/user_manager/user_names.cc
[rename] https://crrev.com/3c1c0889c660cd6dfbc33ac5aca72f0203e7ca02/components/user_manager/user_names.h

Components: Enterprise
Labels: Enterprise-Triaged

Comment 6 Deleted

Comment 7 by tnagel@chromium.org, Nov 21 2016

Labels: -Pri-3 M-57 TT Pri-1
Summary: Adding AD accounts/users to Chrome OS (was: Adding AD accounts/users to ChromeOS)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42839ee8c1195b25fbe327057e10c54f592b6693

commit 42839ee8c1195b25fbe327057e10c54f592b6693
Author: rsorokin <rsorokin@chromium.org>
Date: Mon Nov 28 10:04:55 2016

Fix crash in WizardController for Active Directory devices

BUG= 656992 
TEST=manual

Review-Url: https://codereview.chromium.org/2530193002
Cr-Commit-Position: refs/heads/master@{#434626}

[modify] https://crrev.com/42839ee8c1195b25fbe327057e10c54f592b6693/chrome/browser/chromeos/login/wizard_controller.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/302e3ec3e15d8cc8ddfa6bc481b55289d931c181

commit 302e3ec3e15d8cc8ddfa6bc481b55289d931c181
Author: rsorokin <rsorokin@chromium.org>
Date: Thu Dec 15 13:42:41 2016

Fix crash in WizardController for Active Directory devices

IsRemoraRequisition call.

BUG= 656992 
TEST=manual

Review-Url: https://codereview.chromium.org/2571043004
Cr-Commit-Position: refs/heads/master@{#438820}

[modify] https://crrev.com/302e3ec3e15d8cc8ddfa6bc481b55289d931c181/chrome/browser/chromeos/login/wizard_controller.cc

Status: Started (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9

commit d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9
Author: rsorokin <rsorokin@chromium.org>
Date: Wed Dec 21 18:11:00 2016

Add account_type into AccountId

- Add Active Directory type account
- Rename gaia_id_ to id_.
- Add |AcccountType| param to user_manager::known_user::GetAccountId
- Add |AdFromUserEmailObjGuid| |AdFromUserEmail| functions to create Active Directory account ids.

This CL a preparation for  crbug.com/668130 
Should be fixed after migration (see  crbug.com/668130 )

BUG= 656992 
TEST=none

Review-Url: https://codereview.chromium.org/2529103002
Cr-Commit-Position: refs/heads/master@{#440152}

[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/easy_unlock/bootstrap_manager.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chrome/browser/ui/webui/options/chromeos/user_image_source.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chromeos/cryptohome/cryptohome_parameters.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/chromeos/tpm/tpm_token_info_getter_unittest.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/components/signin/core/account_id/account_id.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/components/signin/core/account_id/account_id.h
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/components/user_manager/known_user.cc
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/components/user_manager/known_user.h
[modify] https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9/components/user_manager/user_manager_base.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/314e8f11777388068b8d07c83d664437da7da52a

commit 314e8f11777388068b8d07c83d664437da7da52a
Author: hcarmona <hcarmona@chromium.org>
Date: Wed Dec 21 19:16:19 2016

Revert of Add account_type into AccountId (patchset #10 id:180001 of https://codereview.chromium.org/2529103002/ )

Reason for revert:
Causing build failure: https://uberchromegw.corp.google.com/i/chromium/builders/Linux%20x64/builds/30384

Original issue's description:
> Add account_type into AccountId
>
> - Add Active Directory type account
> - Rename gaia_id_ to id_.
> - Add |AcccountType| param to user_manager::known_user::GetAccountId
> - Add |AdFromUserEmailObjGuid| |AdFromUserEmail| functions to create Active Directory account ids.
>
> This CL a preparation for  crbug.com/668130 
> Should be fixed after migration (see  crbug.com/668130 )
>
> BUG= 656992 
> TEST=none
>
> Committed: https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9
> Cr-Commit-Position: refs/heads/master@{#440152}

TBR=alemate@chromium.org,stevenjb@chromium.org,atwilson@chromium.org,rogerta@chromium.org,rsorokin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 656992 

Review-Url: https://codereview.chromium.org/2593133002
Cr-Commit-Position: refs/heads/master@{#440173}

[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/easy_unlock/bootstrap_manager.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chrome/browser/ui/webui/options/chromeos/user_image_source.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chromeos/cryptohome/cryptohome_parameters.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/chromeos/tpm/tpm_token_info_getter_unittest.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/components/signin/core/account_id/account_id.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/components/signin/core/account_id/account_id.h
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/components/user_manager/known_user.cc
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/components/user_manager/known_user.h
[modify] https://crrev.com/314e8f11777388068b8d07c83d664437da7da52a/components/user_manager/user_manager_base.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb06787846a2f824cfe48ab4118e000e89249564

commit fb06787846a2f824cfe48ab4118e000e89249564
Author: rsorokin <rsorokin@chromium.org>
Date: Thu Dec 22 14:24:45 2016

Add account_type into AccountId

- Add Active Directory type account
- Rename gaia_id_ to id_.
- Add |AcccountType| param to user_manager::known_user::GetAccountId
- Add |AdFromUserEmailObjGuid| |AdFromUserEmail| functions to create Active Directory account ids.

This CL a preparation for  crbug.com/668130 
Should be fixed after migration (see  crbug.com/668130 )

BUG= 656992 
TEST=none

Committed: https://crrev.com/d297d94d7922ac0ebd6ca1f3db3fff6db3af24b9
Review-Url: https://codereview.chromium.org/2529103002
Cr-Original-Commit-Position: refs/heads/master@{#440152}
Cr-Commit-Position: refs/heads/master@{#440412}

[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/easy_unlock/bootstrap_manager.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/easy_unlock/bootstrap_user_context_initializer.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/easy_unlock/easy_unlock_tpm_key_manager_factory.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/screens/chrome_user_selection_screen.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/supervised/supervised_user_authenticator.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/ui/ash/multi_user/multi_user_window_manager_chromeos_unittest.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chrome/browser/ui/webui/options/chromeos/user_image_source.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chromeos/cryptohome/cryptohome_parameters.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/chromeos/tpm/tpm_token_info_getter_unittest.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/components/signin/core/account_id/account_id.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/components/signin/core/account_id/account_id.h
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/components/user_manager/known_user.cc
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/components/user_manager/known_user.h
[modify] https://crrev.com/fb06787846a2f824cfe48ab4118e000e89249564/components/user_manager/user_manager_base.cc

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7ebd295d2ce1f07a33b4b4231c8f81963a574358

commit 7ebd295d2ce1f07a33b4b4231c8f81963a574358
Author: rsorokin <rsorokin@chromium.org>
Date: Fri Dec 23 15:46:21 2016

Chromad: Add authentication flow

Don't allow Google accounts on Active Directory enrolled devices.
Always enforce online auth for the Active Directory accounts.
Add new type of AccountId for Active directory.

The account_ids should be fixed properly, once mirgration to GaiaIds will be done

BUG= 656992 
TEST=manual
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2519823006
Cr-Commit-Position: refs/heads/master@{#440631}

[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/ash/public/interfaces/session_controller.mojom
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/ash/public/interfaces/session_controller_traits.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/chromeos/login/helper.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/resources/chromeos/login/offline_ad_login.js
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/resources/chromeos/login/screen_gaia_signin.html
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/resources/gaia_auth_host/authenticator.js
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chromeos/dbus/auth_policy_client.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/chromeos/login/auth/user_context.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/components/user_manager/user.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/components/user_manager/user.h
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/components/user_manager/user_manager_base.cc
[modify] https://crrev.com/7ebd295d2ce1f07a33b4b4231c8f81963a574358/components/user_manager/user_type.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment