New issue
Advanced search Search tips

Issue 656983 link

Starred by 1 user
Status: Fixed
Owner:
jdoerrie@chromium.org
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix include syntax for non-system headers.

Project Member Reported by jdoerrie@chromium.org, Oct 18 2016 
Due to the way how GCC looks for include headers, non-system headers should be included using a '#include "my_custom_header.h" syntax. This is done in the vast majority of cases throughout the codebase, but a few occurrences of '#include <my_custom_header.h>' exist. This issue aims to track these cases and to fix them.

References:
- http://en.cppreference.com/w/cpp/preprocessor/include
- https://gcc.gnu.org/onlinedocs/cpp/Include-Syntax.html
- http://stackoverflow.com/q/21593
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c407cea3c723056660b15f09649d2c0fc7c5924

commit 8c407cea3c723056660b15f09649d2c0fc7c5924
Author: jdoerrie <jdoerrie@chromium.org>
Date: Tue Oct 18 14:15:15 2016

Fix Include Syntax

Using the wrong include syntax for non-system headers can lead to cases where
the compiler is unable to find the corresponding file.

This CL aims to fix an improper include syntax for non-sytem headers.

BUG= 656983 

Review-Url: https://codereview.chromium.org/2432443002
Cr-Commit-Position: refs/heads/master@{#425951}

[modify] https://crrev.com/8c407cea3c723056660b15f09649d2c0fc7c5924/components/autofill/content/renderer/form_autofill_util.h
[modify] https://crrev.com/8c407cea3c723056660b15f09649d2c0fc7c5924/components/autofill/content/renderer/password_form_conversion_utils.h

Comment 2 by jdoerrie@chromium.org, Oct 21 2016

Status: Fixed (was: Started)
►

Sign in to add a comment