Regression: Incorrect adblock icon is seen on tab for error page.
Reported by
vvishwak...@etouch.net,
Oct 18 2016
|
||||||
Issue descriptionVersion: 55.0.2883.18 fef9e129659e95716a20748335f5921e324bab8a-refs/branch-heads/2883@{#164} (32/64 bit) OS: Windows (7,8,10), Mac (10.10.5, 10.11.4), Linux (14.04 LTS) What steps will reproduce the problem? 1) Launch chrome, go to above URL and add the extension. 2) Open a New tab, click on omnibox, type ‘c’ and select the first option in suggestion list, error page opens. 3) Observe the error page tab. Disabled adblock icon is seen on tab. Disabled icon of adblock should not be seen. This is a Regression issue broken in M-55, will soon update other info Manual bisect: Good build: 55.0.2865.0 Bad build: 55.0.2866.0
,
Oct 18 2016
,
Oct 18 2016
working on Needs-bisect, will update later.
,
Oct 19 2016
Narrow bisect URL: https://chromium.googlesource.com/chromium/src/+log/a836bd29e3ca8f3c40a3a4108613a61a2a82f5e7..2c5fa0e91fb3fcd0b480856104a793ca3219cca1?pretty=fuller&n=100 Suspecting: r419854
,
Oct 27 2016
Just to update, issue is observed on Ubuntu 14.04 for chrome version 56.0.2902.0. @spqchan@: Gentle ping, This issue is marked as P1 for M55 milestone, can we get any update on this bug if it's related to your change? Issue is broken in M55 and it's already in Beta and will be pushed to stable soon. Thanks.!
,
Oct 27 2016
edwardjung@ - should the favicon be desaturated in this case? This is a file not found error rather than a network error.
,
Oct 27 2016
The file not found is a type of network error and as such has the same behaviour of a desaturated favicon, so this working as intended. ainslie@ do we only want the desaturation to only happen for a subset of net errors? For example offline errors versus others.
,
Oct 27 2016
I'm happy to keep desaturation for the full set of net-errors.
,
Oct 27 2016
Marking as wontfix because per c#7 this is working as intended. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by vvishwak...@etouch.net
, Oct 18 2016