Issue metadata
Sign in to add a comment
|
Regression: Unnecessary focus highlight is seen on disabled 'Display Chrome in this language' checkbox.
Reported by
jshan...@etouch.net,
Oct 18 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 56.0.2894.0 (Official Build) 9e01f1257eb75274157fe7d246869b32d24b155b-refs/heads/master@{#425838}-32/64 bit OS: Windows (7,8,10) Steps: 1. Launch Chrome and navigate to chrome://md-settings 2. Click on Advanced, go to Language section and click on Add language, add 'Afrikaans' 3. Click on iron icon of Afrikaans language and observe. Actual: Unnecessary focus highlight is seen on disabled 'Display Chrome in this language', also pressing down arrow keys focus is directly seen on 'Move to top'. Expected: Focus highlight should not be seen on 'Display Chrome in this language' as it is in disabled for Afrikaans language. This is regression issue broken in M-56 and will soon update the bisect info : Good build:56.0.2891.0 Bad build: 56.0.2892.0 Note: Above issue is not seen Mac and Linux OS.
,
Oct 18 2016
I am able to reproduce this on CrOS. Will take a look and report back with findings.
,
Oct 18 2016
My initial investigation leads me to IronControlState behavior, which steals the focus even if the element is disabled, see [1]. Checking for |disabled| at that line fixes half of the bug (no more unnecessary focus ripple). The other half (pressing down arrow keys focus is directly seen on 'Move to top') still happens though. [1] https://cs.chromium.org/chromium/src/third_party/polymer/v1_0/components-chromium/iron-behaviors/iron-control-state-extracted.js?l=61
,
Oct 18 2016
,
Oct 19 2016
if my interpretation of the spec[1] is correct, negative tab index shouldn't participate in the tab order. imo, <dialog> should not focus() an element with a custom tabindex if it's < 0. here's a reduced repro: https://jsfiddle.net/7gbbbjcr/ [1] https://html.spec.whatwg.org/multipage/interaction.html#negative-tabindex
,
Oct 19 2016
note, if my blink CL[1] is interpreted as The Right Way To Do Stuff, it'd only solve part of the battle here (but it might be OK for our uses). <button tabindex="-1"> will still magically get focus if it comes before <paper-checkbox tabindex="0"> because [reasons]. [1] https://chromiumcodereview.appspot.com/2428333002/
,
Oct 31 2016
btw, my blink CL was NOT interpreted as "The Right Way"
,
Nov 4 2016
,
Nov 11 2016
Issue 664422 has been merged into this issue.
,
Nov 16 2016
Issue 665699 has been merged into this issue.
,
Nov 17 2016
Issue 656906 has been merged into this issue.
,
Dec 5 2016
,
Jan 25 2017
,
Mar 18 2017
,
Mar 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/25958da94dac85cfe9cf3ec07d428fa0d75aab8e commit 25958da94dac85cfe9cf3ec07d428fa0d75aab8e Author: dbeam <dbeam@chromium.org> Date: Sat Mar 18 19:48:52 2017 MD WebUI: fix action menu initial focus to be more like context menus This is easily possible now because <dialog>#showModal() looks into shadow DOM. R=dpapad@chromium.org BUG= 656924 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2755213002 Cr-Commit-Position: refs/heads/master@{#457977} [modify] https://crrev.com/25958da94dac85cfe9cf3ec07d428fa0d75aab8e/chrome/test/data/webui/cr_elements/cr_action_menu_test.js [modify] https://crrev.com/25958da94dac85cfe9cf3ec07d428fa0d75aab8e/ui/webui/resources/cr_elements/cr_action_menu/cr_action_menu.html
,
Mar 21 2017
,
Mar 21 2017
Tested the issue on Chrome Dev# 59.0.3047.0 on Windows and found the issue to be Fixed. No focus is displayed on the options present under iron icon of language. Attaching screencast for reference (only windows). Note: Also checked on Latest CrOS Dev# 59.0.3041.0/9386.0.0 dev channel Minnie and is still reproducible. @dbeam -- Could you please confirm the Fix on Chrome OS, so that verified labels would be added from TE side. Thanks in Advance.
,
Mar 30 2017
Verified on ChromeOS 59.0.3054.0/9409.0.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Oct 18 2016Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)