New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 656918 link

Starred by 1 user
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Oct 2016
Cc:
nyerramilli@chromium.org
█ brajkumar@chromium.org
█ tkonch...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unnecessary blink of 'Sign out' is seen in omnibox after clicking on forward navigation button on MD Settings.

Reported by rk...@etouch.net, Oct 18 2016 
Chrome Version: 55.0.2883.18 Revision fef9e129659e95716a20748335f5921e324bab8a-refs/branch-heads/2883@{#164}
OS: Windows(7,8,10), Mac(10.10.5,10.11.4), Linux

Pre-Condition: Sign in to browser with valid credentials.

What steps will reproduce the problem?
(1) Launch chrome, navigate to chrome://md-settings page and click 'Sign Out' button.
(2) Now click on back navigation button then click on forward and observe.

Actual: 1.Unnecessary blink of Sign out is seen in omnibox after clicking on forward navigation button.
        2.Browser doesnot navigate to chrome://md-settings/sign out page after clicking on forward navigation button.

Expected: 1. No such blink in omnibox should seen.
          2. Browser should navigate to chrome://md-settings/sign out page after clicking on forward navigation button. 

This is a regression issue, broken in 'M-55', will soon update the other info:

Good Build: 55.0.2844.0
Bad Build: 55.0.2845.0
Actual_Video.mp4
741 KB View Download
Expected_Video.mp4
578 KB View Download

Comment 1 by msrchandra@chromium.org, Oct 18 2016

Labels: hasbisect-per-revision
Owner: tommycli@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 55.0.2844.0 (Revision: 415023).
Bad build: 55.0.2845.0 (Revision: 415522).

You are probably looking for a change made after 415327 (known good), but no later than 415328 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/07b17a8e40eb4af58b716e5dc1eba449f11ff920..bd5e51eb0cfaa6620b522ef52f549d7c1f158775

@tommycli -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Thank You.
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d263cf266480fb3472db7b56d54291466226c592

commit d263cf266480fb3472db7b56d54291466226c592
Author: tommycli <tommycli@chromium.org>
Date: Tue Oct 25 02:41:19 2016

MD Settings: Don't auto-close navigable dialogs on popstate.

Previously, we made all cr-dialogs close on popstate. This is good,
except for navigable dialogs.

For navigable dialogs: It should open if the new route is the dialog's
route, and close otherwise. All the navigable dialogs already have code
that implements this behavior, but it conflicts with the popstate
event handler on cr-dialog.

This CL adds a parameter that disables this behavior for navigable
dialogs.

BUG= 656918 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2445713004
Cr-Commit-Position: refs/heads/master@{#427249}

[modify] https://crrev.com/d263cf266480fb3472db7b56d54291466226c592/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.html
[modify] https://crrev.com/d263cf266480fb3472db7b56d54291466226c592/chrome/browser/resources/settings/people_page/people_page.html
[modify] https://crrev.com/d263cf266480fb3472db7b56d54291466226c592/chrome/browser/resources/settings/reset_page/reset_profile_dialog.html
[modify] https://crrev.com/d263cf266480fb3472db7b56d54291466226c592/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.js

Comment 3 by tommycli@chromium.org, Oct 25 2016

Status: Fixed (was: Assigned)

Comment 4 by brajkumar@chromium.org, Oct 27 2016

Cc: brajkumar@chromium.org
Labels: TE-Verified-56.0.2902.0 TE-Verified-M56
Verified the issue on Ubuntu 14.04, Windows-10 and Mac OS 10.12 using chrome latest Dev M56-56.0.2902.0 by following steps mentioned in the original comment. Observed able to navigate backward and forward on chrome://md-settings/signout page as expected. Hence adding TE-verified.

tommycli@ Thanks for the fix, could you please merge the same to latest M55, Since M55 is already in Beta and will be pushed to stable soon.
656918.ogv
2.1 MB View Download

Comment 5 by brajkumar@chromium.org, Nov 2 2016 

tommycli@ - Gentle Ping! can we get any update on this issue regarding M55 beta fix?

Comment 6 by tommycli@chromium.org, Nov 2 2016 

Hey, there's no need to merge it to 55.

MD Settings has not launched yet, so it's not worth the merge.
►

Sign in to add a comment