New issue
Advanced search Search tips

Issue 656895 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.8% regression in memory.top_10_mobile at 424389:424405

Project Member Reported by jgruber@chromium.org, Oct 18 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=656895

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg7bCWugoM


Bot(s) for this bug's original alert(s):

android-nexus9
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Oct 18 2016

Cc: yangguo@chromium.org
Owner: yangguo@chromium.org

=== Auto-CCing suspected CL author yangguo@chromium.org ===

Hi yangguo@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [Math] implement Math.random as TFJ builtin.
Author  : yangguo
Commit description:
  
R=bmeurer@chromium.org
BUG=v8:5049,  v8:5086 

Review-Url: https://codereview.chromium.org/2402363002
Cr-Commit-Position: refs/heads/master@{#40149}
Commit  : 0d8e52123eefaf3858005f96f0db3af037222853
Date    : Tue Oct 11 06:47:15 2016


===== TESTED REVISIONS =====
Revision                       Mean    Std Dev  N  Good?
chromium@424388                202180  2268.57  8  good
chromium@424397                202690  2123.01  8  good
chromium@424398                202615  2415.58  5  good
chromium@424398,v8@b884a51ff2  200275  708.444  5  good
chromium@424398,v8@127798897f  203485  1852.16  5  good
chromium@424398,v8@90ebb7b4dd  201714  2669.18  5  good
chromium@424398,v8@3d5ae0f7d3  201727  2672.55  5  good
chromium@424398,v8@0d8e52123e  209060  1656.29  5  bad    <--
chromium@424399                206821  2348.5   8  bad
chromium@424401                208942  1869.54  5  bad
chromium@424405                206893  2517.57  5  bad

Bisect job ran on: android_nexus9_perf_bisect
Bug ID: 656895

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests memory.top_10_mobile
Test Metric: memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_avg/memory:chrome:renderer_processes:reported_by_chrome:v8:heap:map_space:allocated_objects_size_avg
Relative Change: 2.51%
Score: 99.8

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus9_perf_bisect/builds/2192
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8998484670288267328


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5851793311924224

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
This is due to the TF stub not being force inlined. I'll work on addressing this soon.
Actually, this is somewhat surprising. I thought this was a performance regression when this is actually a memory regression. Will take a look.

Comment 6 by rbyers@chromium.org, Nov 18 2016

Labels: Performance
Status: WontFix (was: Assigned)
This regression has been included in a stable release and that stable channel is now deprecated. I'm closing this so that we won't have unresponsive performance regressions in the future. 

Sign in to add a comment