Add User Action For When User Clicks on A Telephone Intent |
|||||||||
Issue descriptionIt would be great if this covers both explicitly linked telephone numbers (e.g., <a href="tel:8881112222">(888) 111 - 2222</a>) and places where the site did not do the markup. Regarding the latter, via Ted: >>> The phone number detection is quite old and hasn't been touched for a while (qinmin@ is the owners) https://cs.chromium.org/chromium/src/content/renderer/android/phone_number_detector.cc?sq=package:chromium&l=57 Detection done in chrome: https://cs.chromium.org/chromium/src/content/renderer/render_view_impl.cc?q=detectContentIntentAt&sq=package:chromium&l=2766 Triggered by blink: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/WebViewImpl.cpp?q=detectContentIntentAt&sq=package:chromium&dr=C&l=4441 Bounced to the browser: https://cs.chromium.org/chromium/src/content/renderer/render_view_impl.cc?dr=C&q=scheduleContentIntent&sq=package:chromium&l=2781 ... 18,000 indirection steps later: https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java?q=StartContentIntent&sq=package:chromium&l=2847&dr=CSs And actually triggered the intent here: https://cs.chromium.org/chromium/src/content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java?q=onStartContentIntent&sq=package:chromium&l=143&dr=CSs >>>
,
Aug 22 2017
,
Nov 1 2017
These detectors were removed in Chrome, but I wonder if we have metrics for actions triggered in the CS ui?
,
Nov 2 2017
We have a lot of histograms for quick actions triggered in contextual search, logged under ContextualSearch, under Search.ContextualSearchAuickActions.*, but it doesn't look like we're currently recording any user actions. If that's helpful for sequencing, we could add some extra logging. We also used to have a user action logged when the renderer detected a phone number, address or email address (screenshot attached).
,
Nov 2 2017
I think contextual search is a distraction from this bug. If the local detectors have been deprecated, then the only thing remaining from the original request is a way to identify when a user clicks on a telephone intent. Counting would probably suffice; sequencing would be better though there's no immediate use case for it. I don't think either are currently possible. If there are improvements to be made to contextual search logging, please file a different bug.
,
Nov 2 2017
The local detectors have been completely removed.
,
Nov 2 2017
twellington: aren't there still tel: links in the wild? Or does your comment "The local detectors have been completely removed." mean that we no longer make them clickable?
,
Nov 2 2017
If a website explicitly fires an intent when a link is clicked, ExternalNavigationHandler will still handle it. Over to Maria to triage.
,
Nov 2 2017
,
Nov 2 2017
Just to be sure I understand: you want to log a user action in ExternalNavigationHandler when the intent is for a telephony? Who needs this and why?
,
Nov 3 2017
> you want to log a user action in ExternalNavigationHandler when the intent is > for a telephony? Who needs this and why? This request came from someone arranging the talking points for an investor earnings call last year, trying to reflect how much reach Google products have with businesses. Obviously, since we didn't have the statistic then it wasn't mentioned. Nonetheless, I think if it's not hard we should add logging for it because I wouldn't be surprised if it comes up again.
,
Nov 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd5f02c21cd68130a5c9e460b2c71c68891cd303 commit dd5f02c21cd68130a5c9e460b2c71c68891cd303 Author: Maria Khomenko <mariakhomenko@chromium.org> Date: Fri Nov 03 21:33:12 2017 Record an action when user clicks on phone number. BUG=776988 Change-Id: Ic0a5e9ee5e160fcd4722686a5ef4a68c999e4d65 Reviewed-on: https://chromium-review.googlesource.com/753423 Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Reviewed-by: Mark Pearson <mpearson@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#513916} [modify] https://crrev.com/dd5f02c21cd68130a5c9e460b2c71c68891cd303/chrome/android/java/src/org/chromium/chrome/browser/UrlConstants.java [modify] https://crrev.com/dd5f02c21cd68130a5c9e460b2c71c68891cd303/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java [modify] https://crrev.com/dd5f02c21cd68130a5c9e460b2c71c68891cd303/tools/metrics/actions/actions.xml
,
Nov 3 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by mpear...@chromium.org
, Oct 18 2016