New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656878 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[bvt-inline] security_SandboxedServices Failure on veyron_rialto-release/R56-8909.0.0

Project Member Reported by bugdr...@chromeos-lab.google.com.iam.gserviceaccount.com, Oct 18 2016

Issue description

This report is automatically generated to track the following Failure:
Test: security_SandboxedServices.
Suite: bvt-inline.
Chrome Version: 56.0.2890.0.
Build: veyron_rialto-release/R56-8909.0.0.

Reason:
One or more processes failed sandboxing.
build artifacts: https://storage.cloud.google.com/?arg=chromeos-image-archive/veyron_rialto-release/R56-8909.0.0.
results log: http://cautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/81283957-chromeos-test/chromeos4-row4-rack9-host14/debug/.
status log: http://cautotest.corp.google.com/tko/retrieve_logs.cgi?job=/results/81283957-chromeos-test/chromeos4-row4-rack9-host14/status.log.
buildbot stages: NA.
job link: http://cautotest.corp.google.com/afe/#tab_id=view_job&object_id=81283957.

You may want to check the test history on wmatrix: https://wmatrix.googleplex.com/unfiltered?hide_missing=True&tests=security_SandboxedServices
You may also want to check the test retry dashboard in case this is a flakey test: https://wmatrix.googleplex.com/retry_teststats/?days_back=30&tests=security_SandboxedServices


ANCHOR  TestFailure{bvt-inline,security_SandboxedServices,One or more processes failed sandboxing}

 

Comment 1 by joth@chromium.org, Oct 19 2016

Labels: Pri-1
Owner: vapier@chromium.org
@vapier - looks like this was caused by https://chromium-review.googlesource.com/#/c/395730/



Comment 2 by joth@chromium.org, Oct 19 2016

Think it just needs re-baselining.

10/17 21:18:14.971 ERROR|security_Sandboxed:0280| New services are not allowed to run as root, but these are: ['rialto_update_r', 'rialto_modem_wa', 'pppd', 'update_engine_c', 'rialto_timezone']
10/17 21:18:14.978 ERROR|security_Sandboxed:0284| Failed sandboxing: ['rialto_update_r', 'rialto_modem_wa', 'pppd', 'update_engine_c', 'rialto_timezone']


Currently these are expected to be running as root on rialto. 

- pppd could be running any device with modem

- rialto_modem_wa could conceivably be reworked to not run as root.

- rialto_update_r and rialto_timezone may eventually be removed (post go/rialto-kiosk-migration)

- update_engine_c is sub-command called by rialto_update_r script that happened to be running when the test run. (seems this test could be racy / flaky?)


Comment 3 by vapier@chromium.org, Oct 19 2016

Cc: vapier@chromium.org
Owner: joth@chromium.org
i think it's better that the people owning rialto add baselines to match their board.  you can just create a file here to match the services:
  client/site_tests/security_SandboxedServices/baseline.rialto

Comment 4 by joth@chromium.org, Oct 19 2016

What is the format of that file?

And does the first column use the process full name, or truncated name per the error log? (rialto_update_reboot vs rialto_update_r)


Comment 5 by vapier@chromium.org, Oct 19 2016

if you look at the 'baseline' file, it'll show the format

you have to use the truncated name as shown in the logging error output:
10/17 21:18:14.978 ERROR|security_Sandboxed:0284| Failed sandboxing: ['rialto_update_r', 'rialto_modem_wa', 'pppd', 'update_engine_c', 'rialto_timezone']

alternatively, some of those services prob shouldn't be running as root ;)

Comment 6 by joth@chromium.org, Oct 19 2016

I did already look at the existing files for format, but pedns,caps,filter == No,No,No means little to me.

(And yes, I did already mention in #2 that 4 of the 5 processes are planned to be removed or could be made non-root, but getting the release build green again is the priority right now.)

Comment 7 by joth@chromium.org, Oct 19 2016

pppd could be running as root on any chrome os device.
Should that go in the base file?

Comment 8 by joth@chromium.org, Oct 19 2016

(for future reference - the baseline file suffix is derived from board name so the file needed is baseline.veyron_rialto not baseline.rialto)

Comment 9 by vapier@chromium.org, Oct 19 2016

pidns == pid namespace is used
caps == capabilities is used
filter == seccomp is used

it's so obvious when you already know ;).  i'll put together some docs.

Comment 10 Deleted

Comment 11 Deleted

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/eb0052d2cdbe731dbb9ccdb064b17d7602f7d2ca

commit eb0052d2cdbe731dbb9ccdb064b17d7602f7d2ca
Author: Jonathan Dixon <joth@google.com>
Date: Wed Oct 19 17:43:23 2016

security_SandboxedServices: rebaseline rialto root services

BUG= chromium:656878 
TEST=security_SandboxedServices

Change-Id: I6f78ffea6c58154e4ac04b8b746360b3e820d628
Reviewed-on: https://chromium-review.googlesource.com/399895
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Jonathan Dixon <joth@chromium.org>
Reviewed-by: Niranjan Kumar <kumarniranjan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[add] https://crrev.com/eb0052d2cdbe731dbb9ccdb064b17d7602f7d2ca/client/site_tests/security_SandboxedServices/baseline.veyron_rialto

Comment 13 Deleted

Comment 14 Deleted

Comment 15 Deleted

Comment 16 Deleted

Comment 17 Deleted

Comment 18 by joth@chromium.org, Oct 24 2016

Cc: joth@chromium.org
Owner: vapier@chromium.org
@vapier - I rebaselined Rialto and has fixed it there, but a bunch of other boards have started failing since then.
Back to you to determine next steps

ninja-release
tricky-tot-chrome-pfq-informational
ninja-release
peach_pit
Labels: -Restrict-View-Google -autofiled-count-8 -Proj-ninja -Proj-Tricky -bvt -autofiled -proj-Pit
Owner: joth@chromium.org
Status: Fixed
i don't know why those reports are getting lumped in, so let's delete all that noise and close it out

Sign in to add a comment