New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Stop using --manually_grab_svn_rev

Project Member Reported by sdefresne@chromium.org, Oct 18 2016

Issue description

The stable bot and the autoroller bots fail due to the following error (see https://uberchromegw.corp.google.com/i/internal.bling.main/builders/stable-device/builds/313/steps/gclient%20sync/logs/stdio):

gclient.py: error: no such option: --manually_grab_svn_rev

It looks like the option is going to be removed from gclient. The CL was reverted (see https://codereview.chromium.org/2404413002 where the option is ressurected) but the bot seems to not have recovered.

Could you investigate whether the bots are in a stuck state (this could happen if the only call to gclient is using the removed option in which case depot_tools is not updated and the issue won't ever heal itself automatically)?

If the bots manage to get unstuck, the option should still be removed from the bots as it will eventually be removed from depot_tools.

Setting to P0 as this prevents critical bots from working. Please reduce priority when they are working again.
 
Cc: baxley@chromium.org stkhapugin@chromium.org
+cc sheriffs
Cc: tandrii@chromium.org
+tandrii@chromium.org trooper
Every single downstream iOS trybot also appears to be failing with the same error.

This is currently preventing all iOS development.  Can someone please take a look?
Cc: sergeybe...@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/69b1be10a44289cca2bbb1de51605ec28808dea0

commit 69b1be10a44289cca2bbb1de51605ec28808dea0
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Oct 18 12:48:02 2016

Fix typo in --manually_grab_svn_rev deprecated flag.

Chrome on iOS downstream bot still use that flag and they cannot
recover as the flag has been misspelt when resurrected.

TBR=agable@chromium.org
TBR=dnj@chromium.org
BUG= 656865 

Review-Url: https://codereview.chromium.org/2428893002

[modify] https://crrev.com/69b1be10a44289cca2bbb1de51605ec28808dea0/gclient.py

Project Member

Comment 6 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/69b1be10a44289cca2bbb1de51605ec28808dea0

commit 69b1be10a44289cca2bbb1de51605ec28808dea0
Author: sdefresne <sdefresne@chromium.org>
Date: Tue Oct 18 12:48:02 2016

Fix typo in --manually_grab_svn_rev deprecated flag.

Chrome on iOS downstream bot still use that flag and they cannot
recover as the flag has been misspelt when resurrected.

TBR=agable@chromium.org
TBR=dnj@chromium.org
BUG= 656865 

Review-Url: https://codereview.chromium.org/2428893002

[modify] https://crrev.com/69b1be10a44289cca2bbb1de51605ec28808dea0/gclient.py

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/a76a98db1e63802b7c9569712d65ba2076cd8b73

commit a76a98db1e63802b7c9569712d65ba2076cd8b73
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Oct 18 13:00:25 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

depot_tools:
  https://crrev.com/69b1be10a44289cca2bbb1de51605ec28808dea0 Fix typo in --manually_grab_svn_rev deprecated flag. (sdefresne@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 656865 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2424233003

[modify] https://crrev.com/a76a98db1e63802b7c9569712d65ba2076cd8b73/infra/config/recipes.cfg

Project Member

Comment 8 by bugdroid1@chromium.org, Oct 18 2016

sdefresne@ Thanks for quick fix. Is this resolved now?
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 18 2016

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 18 2016

Project Member

Comment 12 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/0bbec0ebd134ba88eb2a788a7cb1991badbc7e65

commit 0bbec0ebd134ba88eb2a788a7cb1991badbc7e65
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Oct 18 13:25:55 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/a76a98db1e63802b7c9569712d65ba2076cd8b73 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/69b1be10a44289cca2bbb1de51605ec28808dea0 Fix typo in --manually_grab_svn_rev deprecated flag. (sdefresne@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG= 656865 

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2423883004

[modify] https://crrev.com/0bbec0ebd134ba88eb2a788a7cb1991badbc7e65/infra/config/recipes.cfg

Labels: -Pri-0 Pri-1
Our tree seems to not be broken after last CL. Lowering priority to P1 - please take a look and see if there is anything left to be done. 
Status: Fixed (was: Untriaged)
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f39e9d7188d82ba960a03317ee94d4388065d095

commit f39e9d7188d82ba960a03317ee94d4388065d095
Author: recipe-roller <recipe-roller@chromium.org>
Date: Tue Oct 18 19:06:53 2016

Roll recipe dependencies (trivial).

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/21d67fdde732b8c961be656d6b6af4828970411a Revert of Use the Chromium-side script to run the PGO benchmarks. (patchset #1 id:40001 of https://codereview.chromium.org/2421363002/ ) (dimu@google.com)
  https://crrev.com/0cb76c4e79c13e8f742769452cc47a856373f352 Reland V8: Run simple-leak-check step on release and trybot (machenbach@chromium.org)
  https://crrev.com/eec0e205b570e93edd338b5204dce218e8af4d77 libyuv: Remove all GYP builders. (kjellander@chromium.org)
  https://crrev.com/4f91b12538a3360e4f70ed0ce9f4805d81ed7dc4 Replace linux_chromium_headless_dbg with linux_chromium_headless_rel (perezju@chromium.org)
  https://crrev.com/8063186c66ba88cfed50669b331771266edc863d libyuv: Set symbol_level=1 for Android builders. (kjellander@chromium.org)
  https://crrev.com/0aca4a6174120097e93b1f220a8c0c959862a084 libyuv: Make Windows trybots also build with VS2013. (kjellander@chromium.org)
  https://crrev.com/a76a98db1e63802b7c9569712d65ba2076cd8b73 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
  https://crrev.com/cd408c7a6c68d0431f0a93982577cd198e757cc7 Skia Infra recipe: add DEPOT_TOOLS env variable for run_unittests (borenet@chromium.org)
  https://crrev.com/eb43e471e1a3d29858940c1469f5c7fb70960e2e Fixing arguments to perf upload script (eyaich@chromium.org)
depot_tools:
  https://crrev.com/69b1be10a44289cca2bbb1de51605ec28808dea0 Fix typo in --manually_grab_svn_rev deprecated flag. (sdefresne@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=linux_chromium_headless_rel,656573,chromium:633253,656865,309849,skia:5723,chromium:652188

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://chromiumcodereview.appspot.com/2432473004
Cr-Commit-Position: refs/heads/master@{#426018}

[modify] https://crrev.com/f39e9d7188d82ba960a03317ee94d4388065d095/infra/config/recipes.cfg

Comment 16 Deleted

Sign in to add a comment