Issue metadata
Sign in to add a comment
|
Update iOS Page Info to mention passwords and credit cards on HTTP pages |
||||||||||||||||||||||||
Issue descriptionSee screenshots. Individual string changes are easy; updating any of the structure is not. I suggest we update at least the HTTP strings to mention passwords and credit cards in M56, so that our warnings for HTTP bad are consistent across platforms. Adding the Hotlist-SecurityIndicators label because this is about consistency with those launches.
,
Oct 18 2016
,
Oct 19 2016
,
Oct 19 2016
,
Oct 20 2016
,
Nov 8 2016
,
Nov 9 2016
tsergeant, you did the Android part of this already, is that right?
,
Nov 9 2016
Updating to only be about iOS.
,
Nov 9 2016
,
Nov 9 2016
Yes, see comment 14 on issue 657148 for screenshots of the changes to Android.
,
Nov 13 2016
Ideally we should release this with the iOS HTTP-bad release. For that release, if we're in a time crunch, it's fine to just update the strings, without updating design (in terms of i.e. adding a colored title, or something) Lucas, you mentioned there were iOS idiosyncracies that might be important for these strings. Can you give us a flavor of what you mean?
,
Nov 16 2016
,
Nov 24 2016
,
Dec 5 2016
lgarron can you take this for M57 to go along with the security indicator change you have in progress?
,
Dec 5 2016
Yep, will do.
,
Jan 10 2017
emilyschechter@: After talking with estark@, I've tried to make a minimal change [1] that *only* affects HTTP pages (including HTTP pages with password fields, which look just like HTTP pages in Page Info) and shows the strings for desktop. This means: - For HTTP (including HTTP with passwords), change the connection section to the HTTP summary and detail strings. - Change the "What do these mean?" link to "Learn more " - Show info icons for the identity and connection sections, for a) alignment with the "Learn more" link, and b) consistency with other WebsiteSettings-based Page Info surfaces. - Do NOT add the subject (domain) at the top of the identity section. This will leave a bunch of inconsistencies, which I would be free to address once this lands. Sound okay? [1] https://docs.google.com/document/d/1s5KzqmVRmWb_S8jnWMJx1N1egnk_53JxEH7CgaOE7ZA/edit#heading=h.8t64hxl1oynz
,
Jan 10 2017
Actually, a more minimal change is to mention the site in the connection section for now.
,
Jan 10 2017
Initial CL at crrev.com/2624653002
,
Jan 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/86e86920236731fba6385c479cf27fd6c0d15655 commit 86e86920236731fba6385c479cf27fd6c0d15655 Author: lgarron <lgarron@chromium.org> Date: Tue Jan 17 19:49:08 2017 iOS: Add the Page Info password/credit card string for HTTP pages. This also updates the "What do these mean?" link to "Learn more" to match Desktop material design. BUG= 656843 Review-Url: https://codereview.chromium.org/2624963004 Cr-Commit-Position: refs/heads/master@{#444114} [modify] https://crrev.com/86e86920236731fba6385c479cf27fd6c0d15655/ios/chrome/browser/ui/omnibox/page_info_model.cc [modify] https://crrev.com/86e86920236731fba6385c479cf27fd6c0d15655/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
,
Jan 19 2017
Screenshot from Canary on a real device.
,
Jan 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6dd3781121d6a697d9d525e9d965f38c72b8df0 commit a6dd3781121d6a697d9d525e9d965f38c72b8df0 Author: lgarron <lgarron@chromium.org> Date: Fri Jan 20 01:23:58 2017 Update Page Info on iOS to an interim Material Design state. This brings it mostly in sync with other platforms by replacing two sections (identity info and connection info) with a single section containing a security summary and a sentence with details about what the security state means. This CL also: - Drops logic to show error strings related to and SHA-1 deprecation, since we don't detail this on desktop and some of these states can't even be detected on WKWebView anymore. - Preserves the layout code for multiple sections, even if we only show a single one now. - Preserves certificate information for devs/power users, since there is no other way to get the info until we have a certificate viewer on iOS (crbug.com/502470). BUG= 680784 , 656843 , 640478 TEST=Visit the following sites and check against the screenshots at crbug.com/680784#c1 : - expired.badssl.com (on iPhone) - mixed.badssl.com (on iPhone) - http-login.badssl.com (on iPhone) - www.google.com (on iPhone) - http.badssl.com (on iPad) Review-Url: https://codereview.chromium.org/2620243005 Cr-Commit-Position: refs/heads/master@{#444919} [modify] https://crrev.com/a6dd3781121d6a697d9d525e9d965f38c72b8df0/ios/chrome/browser/ui/omnibox/page_info_model.cc
,
Jan 24 2017
All the URLs in comment #21 do match with the screen shots present in crbug.com/680784#c1 except for http-login.badssl.com (on iPhone) For the web page http-login.badssl.com (on iPhone) info icon "i" is not displayed on iPhones. Can you please confirm on this? Note: For android devices http-login.badssl.com, do display info icon "i" on mobile phones.
,
Jan 24 2017
Addition to comment #22: Checked on chrome canary version 58.0.2991.0
,
Feb 1 2017
Sorry, that issue forgot to mention how to turn on the relevant flag: 1. Open the Settings app 2. Scroll to Chrome Beta/Dev/Canary and press 3. Scroll down to Experimental Settings and press 4. Scroll to EXTRA FLAGS (ONE PER LINE) 5. Toggle "Append Extra Flags" to ON 6. Set Flag1 to "--mark-non-secure-as=show-non-secure-passwords-cc-ui" (without the quotes)
,
Feb 1 2017
,
Feb 2 2017
,
Feb 15 2017
Verified in M57.0.2987.53 beta Device: iPhone7, iPad Pro iOS: 10.3, 10.1.1 info icon is displayed in omnibox for http sites with login forms. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Oct 18 201674.8 KB
74.8 KB View Download
106 KB
106 KB View Download