New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656841 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Rename ChosenObjectRow back to ChosenObjectView

Project Member Reported by lgar...@chromium.org, Oct 18 2016

Issue description

We kept them as Views.
 
Components: UI>Browser>Omnibox>PageInfo
Components: -UI>Browser>Omnibox>PageInfo UI>Browser>Bubbles>PageInfo
Labels: -Hotlist-PageInfo
Components: -Security>UX
Labels: Hotlist-GoodFirstBug

Comment 6 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Cc: lgar...@chromium.org patricia...@chromium.org
Owner: ----
Status: Started (was: Assigned)
Summary: Rename ChosenObjectRow back to ChosenObjectView (was: Rename {ChosenObject, PermissionSelector}Row back to {...}View)
PermissionSelectorRow doesn't inherit from views::View, but ChosenObjectRow still does, so I think this makes sense to do for ChosenObjectRow only.

WIP here from zhuoyu.qian@samsung.com: https://chromium-review.googlesource.com/c/chromium/src/+/787510
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cc88a4f7ffb2950a70336c689955640bd8ff56d

commit 0cc88a4f7ffb2950a70336c689955640bd8ff56d
Author: zhuoyu.qian <zhuoyu.qian@samsung.com>
Date: Wed Nov 29 05:46:54 2017

Rename ChosenObjectRow back to ChosenObjectView

Rename ChosenObjectRow back to ChosenObjectView and
ChosenObjectRowObserver to ChosenObjectViewObserver.
Rename the files also.

BUG= 656841 

Signed-off-by: zhuoyu.qian <zhuoyu.qian@samsung.com>
Change-Id: I02ed58c66f9d4483afe66f6e7dc2610dc62ae6de
Reviewed-on: https://chromium-review.googlesource.com/787510
Reviewed-by: Patti <patricialor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520022}
[modify] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/92f896ae1d98b16dd7a90635dab2e8a8c8c8935a/chrome/browser/ui/views/page_info/chosen_object_row.h
[delete] https://crrev.com/92f896ae1d98b16dd7a90635dab2e8a8c8c8935a/chrome/browser/ui/views/page_info/chosen_object_row_observer.h
[rename] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/views/page_info/chosen_object_view.cc
[add] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/views/page_info/chosen_object_view.h
[add] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/views/page_info/chosen_object_view_observer.h
[modify] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/views/page_info/page_info_bubble_view.cc
[modify] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/views/page_info/page_info_bubble_view.h
[modify] https://crrev.com/0cc88a4f7ffb2950a70336c689955640bd8ff56d/chrome/browser/ui/views/page_info/page_info_bubble_view_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment