New issue
Advanced search Search tips

Issue 656836 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 578029



Sign in to add a comment

Web fonts intervention result should be logged more accurately

Project Member Reported by tbansal@chromium.org, Oct 18 2016

Issue description

Web fonts intervention result should be logged more accurately.

1) Log result only when there was no CORS error.
2) Log result only when font display was set to auto.
3) If the font failed to load, it should be considered as a 
longLimitExceeded event.
 
Cc: toyoshim@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f885eafc877e4170ac854794a7a33d72e1b0269

commit 6f885eafc877e4170ac854794a7a33d72e1b0269
Author: tbansal <tbansal@chromium.org>
Date: Fri Oct 21 21:31:16 2016

Log web fonts intervention result more accurately

1) Log result only when there was no CORS error.
2) Log result only when font display was set to auto since
intervention is run only when the font display is auto.
3) Do not log result if the font failed to load.

BUG= 656836 

Review-Url: https://chromiumcodereview.appspot.com/2431503002
Cr-Commit-Position: refs/heads/master@{#426891}

[modify] https://crrev.com/6f885eafc877e4170ac854794a7a33d72e1b0269/third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp
[modify] https://crrev.com/6f885eafc877e4170ac854794a7a33d72e1b0269/third_party/WebKit/Source/core/css/RemoteFontFaceSource.h

Labels: M-56
Status: Fixed (was: Started)
Components: Internals>Network>NetworkQuality
Labels: -nqe
Blocking: 578029

Sign in to add a comment