New issue
Advanced search Search tips

Issue 656835 link

Starred by 1 user
Status: Fixed
Owner:
xing...@intel.com
Closed: Oct 2016
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

A trailing whitespace in CSSMediaRule::cssText

Project Member Reported by xing...@intel.com, Oct 18 2016 
What steps will reproduce the problem?
(1) Put LayoutTests/resources in attached file parent folder.
(2) Launch the attached file.
(3)

What is the expected output?
PASS. 

What do you see instead?
FAIL due to a trailing whitespace.
The attached case passes in FF. But fail in chrome.

This is split from https://codereview.chromium.org/2416893002/.
condition-cssom.html
1.3 KB View Download

Comment 1 by xing...@intel.com, Oct 18 2016

Status: Assigned (was: Untriaged)

Comment 2 by xing...@intel.com, Oct 18 2016

Components: Blink>CSS

Comment 3 by bugsnash@chromium.org, Oct 18 2016

Labels: Test-Layout
Which is the failing layout test?

Comment 4 by xing...@intel.com, Oct 19 2016

Description: Show this description

Comment 5 by xing...@intel.com, Oct 19 2016

Description: Show this description

Comment 6 by xing...@intel.com, Oct 19 2016

Description: Show this description

Comment 7 by xing...@intel.com, Oct 19 2016

Description: Show this description
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be9a3bd6a648138d1a075bd870ed9e10baa6f478

commit be9a3bd6a648138d1a075bd870ed9e10baa6f478
Author: xing.xu <xing.xu@intel.com>
Date: Wed Oct 19 16:56:59 2016

Remove the trailing whitespace in CSSMediaRule::cssText

After remove this whitespace, case LayoutTests/css3/condition-cssom.html can
pass in both Firefox and Chrome.

BUG= 656835 

Review-Url: https://chromiumcodereview.appspot.com/2428223002
Cr-Commit-Position: refs/heads/master@{#426226}

[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/css3/condition-cssom.html
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/css3/device-adapt/viewport-at-rule-parsing.html
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/css3/supports-cssom-expected.txt
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/css3/supports-cssom.html
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/fast/css/resources/insertRule-media.js
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/fast/dom/css-dom-read-2-expected.txt
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt
[modify] https://crrev.com/be9a3bd6a648138d1a075bd870ed9e10baa6f478/third_party/WebKit/Source/core/css/CSSMediaRule.cpp

Comment 9 by xing...@intel.com, Oct 20 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment