New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 656834 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Track SES=0 metric explicitly for Site Engagement

Project Member Reported by kcaratt...@chromium.org, Oct 18 2016

Issue description

We have UMA metrics for the bucket 0-1, but don't track 0 explicitly. We should.

 

Comment 1 by raymes@chromium.org, Nov 30 2016

Components: -Security>UX
Labels: Team-Security-UX
Components: Internals>Permissions>SiteEngagement
Summary: Track SES=0 metric explicitly for Site Engagement (was: Track SES=0 metric explicitly for Site ENgagement)
Cc: kcaratt...@chromium.org
Status: Available (was: Assigned)
Owner: charleszhao@chromium.org
Status: Assigned (was: Available)
Hi Charles, here is one of the Site Engagement metrics bugs I mentioned. Dom or I can help you get started if you have any questions.

Comment 6 Deleted

Status: Started (was: Assigned)
Hi Kendra, what is this bucket 0-1? Can you point me to the code where SES=1 is counted?
I believe you can find that engagement metrics here: https://cs.chromium.org/chromium/src/chrome/browser/engagement/site_engagement_metrics.cc

I don't think we count SES=1 explicitly, we just have the histogram.

Thanks,
Kendra
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/169ed39de473bb196dcb5960e4c19ced3336de4e

commit 169ed39de473bb196dcb5960e4c19ced3336de4e
Author: charleszhao <charleszhao@chromium.org>
Date: Mon Jan 30 03:50:34 2017

(1) Add a new histogram for EngagementScore to check whether it's zero
or non-zero.

(2) The score is treated as 0 if it's less than  ScoreCleanupThreshold.

BUG= 656834 

Review-Url: https://codereview.chromium.org/2633283002
Cr-Commit-Position: refs/heads/master@{#446956}

[modify] https://crrev.com/169ed39de473bb196dcb5960e4c19ced3336de4e/chrome/browser/engagement/site_engagement_metrics.cc
[modify] https://crrev.com/169ed39de473bb196dcb5960e4c19ced3336de4e/chrome/browser/engagement/site_engagement_metrics.h
[modify] https://crrev.com/169ed39de473bb196dcb5960e4c19ced3336de4e/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)

Sign in to add a comment