New issue
Advanced search Search tips

Issue 656821 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 768576
issue 768586



Sign in to add a comment

clang-format/java: space missing after assert if assert is followed by a (

Project Member Reported by mge...@chromium.org, Oct 17 2016

Issue description

I wrote a line that was too long, so git cl upload failed with an error and told me to run git cl format. I ran git cl format, amended my commit, and tried to upload again. This time the upload failed with an error because there was now no space immediately after an "assert". I went and put back the space while changing nothing else, tried to upload a third time, and got a warning telling me to run git cl format.

The line having the issue is line 644 on the right in https://codereview.chromium.org/2422993004/diff/20001/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java.
 
Components: Build

Comment 2 by thakis@chromium.org, Sep 25 2017

Blockedon: 768576

Comment 3 by thakis@chromium.org, Sep 25 2017

Owner: thakis@chromium.org
Status: Started (was: Untriaged)
Summary: clang-format/java: space missing after assert if assert is followed by a ( (was: Dueling code formatting presubmits in Java)
I fixed the missing space after assert in http://llvm.org/viewvc/llvm-project?rev=314172&view=rev , we'll get that after the next clang-format roll. I filed  issue 768576  for the "dueling systems" problem.

Comment 4 by thakis@chromium.org, Sep 25 2017

Blockedon: 768586
Status: Fixed (was: Started)
A clang-format with the fix got deployed on Nov 21 2018.

Sign in to add a comment