clang-format/java: space missing after assert if assert is followed by a ( |
|||||
Issue descriptionI wrote a line that was too long, so git cl upload failed with an error and told me to run git cl format. I ran git cl format, amended my commit, and tried to upload again. This time the upload failed with an error because there was now no space immediately after an "assert". I went and put back the space while changing nothing else, tried to upload a third time, and got a warning telling me to run git cl format. The line having the issue is line 644 on the right in https://codereview.chromium.org/2422993004/diff/20001/components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java.
,
Sep 25 2017
,
Sep 25 2017
I fixed the missing space after assert in http://llvm.org/viewvc/llvm-project?rev=314172&view=rev , we'll get that after the next clang-format roll. I filed issue 768576 for the "dueling systems" problem.
,
Sep 25 2017
,
Nov 26
A clang-format with the fix got deployed on Nov 21 2018. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dpranke@chromium.org
, Jun 15 2017