Enable content_browsertests for ImageCapture on platforms with real cameras |
||||||||
Issue descriptionBecause they are only running with the FakeVCD now [1] This was tried before, but got reverted due to flakyness, probably because the resolution of the Photos was too large and made the test timeout: https://bugs.chromium.org/p/chromium/issues/detail?id=634811 [1] https://cs.chromium.org/chromium/src/content/browser/webrtc/webrtc_image_capture_browsertest.cc?q=webrtcimagecapture&sq=package:chromium&dr=CSs&l=42
,
Oct 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b084f6a7f231d2458a0c43e371cfe82dafbed7a4 commit b084f6a7f231d2458a0c43e371cfe82dafbed7a4 Author: mcasas <mcasas@chromium.org> Date: Tue Oct 18 00:29:41 2016 ImageCapture content_browsertests: bugfix flag passing Switches under |kEnableBlinkFeatures| shoud be passed as comma separated, but they are separated on ToT: the last one would override the others. (Probably that's part of the reasons these tests have been troublesome). This CL solves that. Also, this CL removes the superfluous 'CreateAnd' test name prefix. BUG=656810 Review-Url: https://codereview.chromium.org/2428753002 Cr-Commit-Position: refs/heads/master@{#425833} [modify] https://crrev.com/b084f6a7f231d2458a0c43e371cfe82dafbed7a4/content/browser/webrtc/webrtc_image_capture_browsertest.cc
,
Oct 18 2016
,
Oct 27 2016
,
Oct 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4 commit 92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4 Author: mcasas <mcasas@chromium.org> Date: Fri Oct 28 18:28:17 2016 Image Capture: enable content_browsertests in Linux/CrOs, This CL updates getUserMedia() constraint syntax, which I suspect is part of the reason why sometimes these tests have timed out (if the video resolution is too large, it may very well jam the bot). With that small update this CL enables the tests for CrOs/Linux. BUG=656810 Review-Url: https://codereview.chromium.org/2456193004 Cr-Commit-Position: refs/heads/master@{#428433} [modify] https://crrev.com/92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4/content/browser/webrtc/webrtc_image_capture_browsertest.cc [modify] https://crrev.com/92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4/content/test/data/media/image_capture_test.html
,
Nov 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6377f417200f471ee4fdede3d10acf00ecca6d0d commit 6377f417200f471ee4fdede3d10acf00ecca6d0d Author: mcasas <mcasas@chromium.org> Date: Wed Nov 02 19:47:40 2016 Correct typo: Image Capture: enable content_browsertests in Linux/CrOs ToT reads as if the test-with-fake-device-false is for all platforms except OS_LINUX, it should be the other way around. BUG=656810, 661172 TBR=xianglu@chromium.org since this is a quick trivial fix Review-Url: https://codereview.chromium.org/2471163003 Cr-Commit-Position: refs/heads/master@{#429372} [modify] https://crrev.com/6377f417200f471ee4fdede3d10acf00ecca6d0d/content/browser/webrtc/webrtc_image_capture_browsertest.cc
,
Nov 15 2016
Is this finished? Will it make it into M56 (branch point on Nov 16)?
,
Nov 23 2016
,
Apr 20 2017
Issues not modified in last 50 days aren't on track to ship in next release.
,
May 18 2017
,
Jun 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/abbc673ca0a1c1162909fbc4aeac6a9da2086ce7 commit abbc673ca0a1c1162909fbc4aeac6a9da2086ce7 Author: John Budorick <jbudorick@chromium.org> Date: Thu Jun 01 22:34:56 2017 Revert "Image Capture: Enable browser tests in Mac and Android" This reverts commit b9cd452c3d6276cfe5c36949439fcc4b5cf3487e. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=728792 Original change's description: > Image Capture: Enable browser tests in Mac and Android > > This CL enables Image Capture browser test in Mac and Android; this test > needs a real-ish camera, so it's only part of the webrtc infra, which is > run explicitly in "large bots" [1]. > > Also git cl format restyled the code a bit. > > [1] https://build.chromium.org/p/chromium.webrtc/waterfall > > > Bug: 656810 > Change-Id: Iadc2fa1b4b5b56c3e06288b73e452a40e15b3426 > Reviewed-on: https://chromium-review.googlesource.com/521263 > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#476350} TBR=scheib@chromium.org,mcasas@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 656810 Change-Id: I094b9d51dbf46f9e1a96458d6fe7264aae18cff1 Reviewed-on: https://chromium-review.googlesource.com/521708 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#476460} [modify] https://crrev.com/abbc673ca0a1c1162909fbc4aeac6a9da2086ce7/content/browser/webrtc/webrtc_image_capture_browsertest.cc
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cce1aed0e9e202a1883acab1631db3fce3171afe commit cce1aed0e9e202a1883acab1631db3fce3171afe Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Jun 02 17:34:35 2017 RELAND: Image Capture: Enable browser tests in Mac (only) This CL is a refry of https://crrev.com/c/521263 which was reverted (in https://crrev.com/c/521708) due to a Thread checker being hit in Android bots. This CL lands the Mac only part to let it roll through all bots. Original CL description: ----------------------------------------------- This CL enables Image Capture browser test in Mac and Android; this test needs a real-ish camera, so it's only part of the webrtc infra, which is run explicitly in "large bots" [1]. Also git cl format restyled the code a bit. [1] https://build.chromium.org/p/chromium.webrtc/waterfall Bug: 656810 Change-Id: I9493e2d04c9f9bba18faff92bbdef22c6c91c27b Reviewed-on: https://chromium-review.googlesource.com/522743 Reviewed-by: Vincent Scheib <scheib@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#476708} [modify] https://crrev.com/cce1aed0e9e202a1883acab1631db3fce3171afe/content/browser/webrtc/webrtc_image_capture_browsertest.cc
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7b659cc060f22d7ee9dd2e3912a149df4d5d4611 commit 7b659cc060f22d7ee9dd2e3912a149df4d5d4611 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Thu Jun 08 00:35:14 2017 Image Capture: correct thread checking and enable browser tests - Android This CL is a refactoring of a previous landing that got reverted (in https://crbug.com/728792 ) due to an assertOnUiThread() being hit because VideoCaptureCamera2 is, of course, not running on UI thread but on some background thread. This CL corrects the check to simply check that all public methods are called on the same Looper. This CL also enables the image capture browser test in Android, and allows for the frames produced by grabFrame() in the test to be rotated (which happens if the test device is in landscape position). Bug: 656810 Change-Id: I421074f9fc26a7c5f8a3cd2fb9cd4f4d7b5ad509 Reviewed-on: https://chromium-review.googlesource.com/527337 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#477828} [modify] https://crrev.com/7b659cc060f22d7ee9dd2e3912a149df4d5d4611/content/browser/webrtc/webrtc_image_capture_browsertest.cc [modify] https://crrev.com/7b659cc060f22d7ee9dd2e3912a149df4d5d4611/content/test/data/media/image_capture_test.html [modify] https://crrev.com/7b659cc060f22d7ee9dd2e3912a149df4d5d4611/media/capture/video/android/java/src/org/chromium/media/VideoCaptureCamera2.java
,
Jun 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8214bacc307012249e0628661907781214e1c8e1 commit 8214bacc307012249e0628661907781214e1c8e1 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Fri Jun 09 16:10:18 2017 Image Capture: add more content_browsertests This CL adds 3 new tests to image capture's content_browsertests: - GetTrackCapabilities and GetTrackSettings simply retrieve those dictionaries, testing that nothing crashes. - ManipulateZoom retrieves the capabilities and, if zoom is supported (it is, at least, when using the fake device), then it tries to configure it to current_zoom + zoom_step, then reads back the value and sees if it coincides. ToT's GetCapabilities case is renamed to GetPhotoCapabilities. Bug: 656810 Change-Id: I6097425bd800b1034be9a121c6d6057788dce777 Reviewed-on: https://chromium-review.googlesource.com/528020 Reviewed-by: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#478297} [modify] https://crrev.com/8214bacc307012249e0628661907781214e1c8e1/content/browser/webrtc/webrtc_image_capture_browsertest.cc [modify] https://crrev.com/8214bacc307012249e0628661907781214e1c8e1/content/test/data/media/image_capture_test.html
,
Jun 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/377f71877f1da432e31fa19fbc9f464ae5d5c285 commit 377f71877f1da432e31fa19fbc9f464ae5d5c285 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Sat Jun 10 00:51:20 2017 Image Capture: Skip 3 flaky content_browsertest test cases in Android Skip 3 flaky content browsertests in Android because it seems to upset the mojo channel underneath and fails consistently on the bots. The tests are: GetTrackCapabilities, GetTrackSettings and ManipulateZoom. I'll fix them and reenable. Bug: 731904 , 656810 Change-Id: I23f685e2edd4893a93e8bc64a64605c7ded1255c Reviewed-on: https://chromium-review.googlesource.com/530264 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#478481} [modify] https://crrev.com/377f71877f1da432e31fa19fbc9f464ae5d5c285/content/browser/webrtc/webrtc_image_capture_browsertest.cc
,
Jun 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e963ee8ad0c396688f3ce5d86d880a60d3e19d8 commit 1e963ee8ad0c396688f3ce5d86d880a60d3e19d8 Author: Miguel Casas-Sanchez <mcasas@chromium.org> Date: Sat Jun 10 04:25:55 2017 Image Capture: reenable disabled android content_browsertests Some android content_browsertests were disabled because of a crash in a mojo DCHECK : ImageCapture tries to retrieve the capabilities of the Device upon construction and asynchronously. If the test finishes early, this request is in flight and we hit a DCHECK. To work around this, we introduce a delay in the form of a request of getPhotoCapabilities(), which goes through the same pipe and that we can control from JS. This is a bandaid until a more permanent solution comes to https://crbug.com/711524. Also, ManipulateZoom hit in some devices a numerical accuracy problem, e.g. |zoom| was increase by 0.1 but when retrieved it was read as 0.100001. This CL also fixes that problem. Bug: 731904 , 656810 Change-Id: Ifc99d0048b704d0d82584b423cce7d28ddba6e0e Reviewed-on: https://chromium-review.googlesource.com/530513 Reviewed-by: Vincent Scheib <scheib@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#478510} [modify] https://crrev.com/1e963ee8ad0c396688f3ce5d86d880a60d3e19d8/content/browser/webrtc/webrtc_image_capture_browsertest.cc [modify] https://crrev.com/1e963ee8ad0c396688f3ce5d86d880a60d3e19d8/content/test/data/media/image_capture_test.html
,
Sep 5 2017
Removing myself as owner of these issues are marking them for retriaging.
,
Sep 5 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mcasas@chromium.org
, Oct 17 2016